Change default service_name values Part 2
#2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarirhamza
changed the title
service_name values Part 2
zarirhamza
force-pushed
the
zarir/service-name-integrations-part-two
branch
from
02761f1
to
47a3bcf
Compare
github-actions
bot
added
appsec
zarirhamza
removed
profiling
zarirhamza
force-pushed
the
zarir/service-name-integrations-part-two
branch
from
47a3bcf
to
02761f1
Compare
zarirhamza
force-pushed
the
zarir/service-name-integrations
branch
from
a693525
to
7bcf3b0
Compare
…h 'origin' into zarir/service-name-integrations-part-two
github-actions
bot
added
appsec
zarirhamza
removed
core
…ub.com/DataDog/dd-trace-rb into zarir/service-name-integrations-part-two
… defined as service name
marcotc
approved these changes
May 1, 2023
There was a problem hiding this comment.
Looks great, @zarirhamza!
Are there still missing integrations to come in a future PR, or this is basically it?
This is the final PR! If it could be merged, that would be perfect, thank you! |
|
Is there any context on the why in this change? The PR also doesn't link to the previous PR :( |
|
The previous PR is here - #2760 This is in preparation for an upcoming feature, still being worked on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process to change all default values for
service_namesper integration toDD_SERVICEservice_namevalues based on span attribute schema version. If version is v0, the default stays as is, otherwise if it is version v1, the default changes toDD_SERVICEsettings_spec.rbper integration that tests the switching of defaults between v0 and v1.peer.servicevalues behindv0schema version only as there will be changes to the value based on version in the future.Affected integrations:
httpclient,httprb,mongodb,mysql2,pg,presto,racecar,rack,redis,rest_client,sequel