-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag AppSec on Rack top-level span #2858
Merged
Merged
Commits on May 26, 2023
-
Tag Appsec on Rack top-level span
AppSec discovers service name based on top-level span. Tagging at trace level results in tags on the trace root span, which is usually Rack's top-level span. When request queuing is enabeld, though, a synthetic span is added in front, representing a service outside the application. This tag then gets mistakenly tagged with AppSec information, resulting in much confusion. The situation gets even trickier with partial flushing, as partially flushed spans may receive a trace tag. Ensuring we tag the proper span should solve both issues.
Configuration menu - View commit details
-
Copy full SHA for 9aee690 - Browse repository at this point
Copy the full SHA 9aee690View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5279f6b - Browse repository at this point
Copy the full SHA 5279f6bView commit details -
[WIP] Wrap contextual information in a scope object
- Create a AppSec::Scope concept to capture toplevel references - Extract context management out of Processor to the more general Scope class - Propagate Scope instead of Context through Rack - Refactor Processor::Context users to find context through Scope instead
Configuration menu - View commit details
-
Copy full SHA for f3b4998 - Browse repository at this point
Copy the full SHA f3b4998View commit details -
Configuration menu - View commit details
-
Copy full SHA for 114b7a0 - Browse repository at this point
Copy the full SHA 114b7a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e4a227 - Browse repository at this point
Copy the full SHA 6e4a227View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b03e2b - Browse repository at this point
Copy the full SHA 3b03e2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3bbf40 - Browse repository at this point
Copy the full SHA d3bbf40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65581ba - Browse repository at this point
Copy the full SHA 65581baView commit details
Commits on May 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3080fb7 - Browse repository at this point
Copy the full SHA 3080fb7View commit details
Commits on May 31, 2023
-
fix broken test. Issue was that the env key for the waf context has c…
…hanged to datadog.appsec.scope
Configuration menu - View commit details
-
Copy full SHA for d3f44ed - Browse repository at this point
Copy the full SHA d3f44edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cb953a - Browse repository at this point
Copy the full SHA 9cb953aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bdd5c6 - Browse repository at this point
Copy the full SHA 3bdd5c6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.