Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag AppSec on Rack top-level span #2858

Merged
merged 12 commits into from
Jun 1, 2023
Merged

Commits on May 26, 2023

  1. Tag Appsec on Rack top-level span

    AppSec discovers service name based on top-level span. Tagging at trace
    level results in tags on the trace root span, which is usually Rack's
    top-level span.
    
    When request queuing is enabeld, though, a synthetic span is added in
    front, representing a service outside the application. This tag then
    gets mistakenly tagged with AppSec information, resulting in much
    confusion.
    
    The situation gets even trickier with partial flushing, as partially
    flushed spans may receive a trace tag.
    
    Ensuring we tag the proper span should solve both issues.
    lloeki committed May 26, 2023
    Configuration menu
    Copy the full SHA
    9aee690 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5279f6b View commit details
    Browse the repository at this point in the history
  3. [WIP] Wrap contextual information in a scope object

    - Create a AppSec::Scope concept to capture toplevel references
    - Extract context management out of Processor to the more general Scope class
    - Propagate Scope instead of Context through Rack
    - Refactor Processor::Context users to find context through Scope instead
    lloeki committed May 26, 2023
    Configuration menu
    Copy the full SHA
    f3b4998 View commit details
    Browse the repository at this point in the history
  4. [WIP] Fix signatures

    lloeki committed May 26, 2023
    Configuration menu
    Copy the full SHA
    114b7a0 View commit details
    Browse the repository at this point in the history
  5. [WIP] Fix specs

    lloeki committed May 26, 2023
    Configuration menu
    Copy the full SHA
    6e4a227 View commit details
    Browse the repository at this point in the history
  6. [WIP] Add scope spec

    lloeki committed May 26, 2023
    Configuration menu
    Copy the full SHA
    3b03e2b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d3bbf40 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    65581ba View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Configuration menu
    Copy the full SHA
    3080fb7 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. fix broken test. Issue was that the env key for the waf context has c…

    …hanged to datadog.appsec.scope
    GustavoCaso committed May 31, 2023
    Configuration menu
    Copy the full SHA
    d3f44ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9cb953a View commit details
    Browse the repository at this point in the history
  3. fix rubocop

    GustavoCaso committed May 31, 2023
    Configuration menu
    Copy the full SHA
    3bdd5c6 View commit details
    Browse the repository at this point in the history