Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPSEC-9942] Change the value format for the WAF address server.request.query #2903

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

GustavoCaso
Copy link
Member

What does this PR do?

The value is expected to be a hash where the keys are strings, and the value is an array of strings.

Motivation

Additional Notes

How to test the change?

CI

@GustavoCaso GustavoCaso requested a review from a team June 7, 2023 16:11
@github-actions github-actions bot added appsec Application Security monitoring product integrations Involves tracing integrations labels Jun 7, 2023
@GustavoCaso GustavoCaso changed the title Change the value format for the WAF address server.request.query [APPSEC-9942] Change the value format for the WAF address server.request.query Jun 7, 2023
The value is expected to be a hash where the keys are string,
and the value is an array of strings.
Copy link
Contributor

@lloeki lloeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment update needed

lib/datadog/appsec/contrib/rack/gateway/request.rb Outdated Show resolved Hide resolved
Co-authored-by: Loic Nageleisen <loic.nageleisen@datadoghq.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2903 (cf1bc7b) into master (d3bdba5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2903   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files        1268     1268           
  Lines       70031    70034    +3     
  Branches     3195     3195           
=======================================
+ Hits        68697    68701    +4     
+ Misses       1334     1333    -1     
Impacted Files Coverage Δ
lib/datadog/appsec/contrib/rack/gateway/request.rb 100.00% <100.00%> (ø)
...atadog/appsec/contrib/rack/gateway/request_spec.rb 100.00% <100.00%> (ø)
...tadog/appsec/contrib/rack/reactive/request_spec.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GustavoCaso GustavoCaso merged commit 39a8707 into master Jun 9, 2023
@GustavoCaso GustavoCaso deleted the appsec-pass-query-as-a-hash branch June 9, 2023 07:26
@github-actions github-actions bot added this to the 1.13.0 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants