Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gitlab pipeline for host injection #2941
Add gitlab pipeline for host injection #2941
Changes from 12 commits
2b29cb5
02237e7
d14c680
59a584e
54520f4
26ad459
2caa84a
11adbde
faf2c66
7edbcbd
0ddad29
7d83048
2cc2d82
22979ff
71961bc
acf28ed
98f2578
4e00f2f
4cc3c73
5ed201e
1e2d17e
559c1e7
37503a9
f41c4bb
fa37f81
8271515
b5bc658
8700cac
63eecd1
9e1fde5
9581a39
467d6b4
e880da7
a74ceaf
99c1818
0cbeb7e
c20f314
bc544f0
be71f96
2719fbc
d0e9bd9
8dd90f2
06670f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intention here to build a
rpm
(ordeb
) with the gems already installed and the dependencies pre-compiled?Because that usually means that we need to have variants for every Ruby supported, it's usually problematic to pick a native extension that was compiled for some Ruby version and then use it a different Ruby version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file seems like it copies a lot over from
auto_inject.rb
. Which in this case... may be easier than shipping multiple files.Nevertheless, I suggest trying to refactor the common bits so that we could keep them in-sync by a simple copy/paste, as right now they're in a similar-but-not-the-same situation, which is a slightly dangerous middle ground to be in, because we can easily introduce bugs when trying to keep them in-sync, or forget to update one of them.