Add rpc.service tag to grpc client spans #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
approved these changes
Jul 18, 2023
Codecov Report
@@ Coverage Diff @@
## master #2962 +/- ##
==========================================
- Coverage 98.07% 98.07% -0.01%
==========================================
Files 1301 1301
Lines 72083 72091 +8
Branches 3310 3312 +2
==========================================
+ Hits 70699 70705 +6
- Misses 1384 1386 +2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add rpc.service tag for grpc client spans
Motivation
This tag will be used as precursor/source for
peer.service.Additional Notes
How to test the change?