[PROF-7966] Add passenger testing to rack integration app #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: This PR adds one more webserver to the rack integration testing app: Phusion Passenger. **Motivation**: In #2976 a customer reported an issue with profiling apps running on passenger. I'm adding passenger to our test suite to avoid any future regressions. **Additional Notes**: I've actually tested that the customer issue does show up on our integration app if I revert the changes from #2978. **How to test the change?**: Validate that the rack CI app is running with passenger as well.
TonyCTHsu
approved these changes
Jul 25, 2023
Codecov Report
@@ Coverage Diff @@
## master #2998 +/- ##
==========================================
- Coverage 98.09% 98.09% -0.01%
==========================================
Files 1305 1305
Lines 72731 72731
Branches 3360 3360
==========================================
- Hits 71343 71342 -1
- Misses 1388 1389 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR adds one more webserver to the rack integration testing app: Phusion Passenger.
Motivation:
In #2976 a customer reported an issue with profiling apps running on passenger. I'm adding passenger to our test suite to avoid any future regressions.
Additional Notes:
I've actually tested that the customer issue does show up on our integration app if I revert the changes from #2978.
How to test the change?:
Validate that the rack CI app is running with passenger as well.