Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor EnvironmentLogger #3020

Merged
merged 8 commits into from
Aug 15, 2023
Merged

Refactor EnvironmentLogger #3020

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e4e272a
initial refactoring draft
sarahchen6 Jul 26, 2023
25965e4
second refactoring with EnvironmentLogging as a class
sarahchen6 Jul 31, 2023
5b5a01b
final refactoring with collect_and_log!
sarahchen6 Aug 2, 2023
017ca81
addressing final unit test
sarahchen6 Aug 8, 2023
a3e7ee1
rebasing onto master
sarahchen6 Aug 9, 2023
b61584c
clean up to pass last main suite test, CircleCI integrations, and Git…
sarahchen6 Aug 10, 2023
263a0eb
address github comments
sarahchen6 Aug 11, 2023
4632878
updated unit tests to use more mocking and stubbing
sarahchen6 Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Steepfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ target :ddtrace do
ignore 'lib/datadog/profiling/collectors/cpu_and_wall_time_worker.rb'
ignore 'lib/datadog/profiling/collectors/old_stack.rb'
ignore 'lib/datadog/profiling/collectors/stack.rb'
ignore 'lib/datadog/profiling/diagnostics/environment_logger.rb'
ignore 'lib/datadog/profiling/encoding/profile.rb'
ignore 'lib/datadog/profiling/event.rb'
ignore 'lib/datadog/profiling/events/stack.rb'
Expand Down Expand Up @@ -554,6 +555,7 @@ target :ddtrace do
ignore 'lib/datadog/tracing/contrib/utils/quantization/hash.rb'
ignore 'lib/datadog/tracing/contrib/utils/quantization/http.rb'
ignore 'lib/datadog/tracing/correlation.rb'
ignore 'lib/datadog/tracing/diagnostics/environment_logger.rb'
ignore 'lib/datadog/tracing/diagnostics/ext.rb'
ignore 'lib/datadog/tracing/diagnostics/health.rb'
ignore 'lib/datadog/tracing/distributed/b3_multi.rb'
Expand Down
2 changes: 2 additions & 0 deletions lib/datadog/core/configuration/components.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,8 @@ def startup!(settings)
else
@logger.debug('Profiling is disabled')
end

Core::Diagnostics::EnvironmentLogger.collect_and_log!
end

# Shuts down all the components in use.
Expand Down
Loading
Loading