Disable Telemetry and Remote Configuration in development environments #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@delner, do you think we should also set |
ivoanjo
reviewed
Aug 10, 2023
TonyCTHsu
approved these changes
Aug 10, 2023
Merged
This was referenced Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
By default, it disables the Telemetry and Remote Configuration background workers, which can send HTTP requests, in any environment that is detected as a development environment. See #3036 for the information about the detection logic.
Motivation
Fixes #2823
ddtracecan cause the test suite for the application to fail whenddtracesends unexpected HTTP requests in the background. These requests are rarely desired and only cause noise add overhead.Additional Notes
It's still possible to enable these features in a development environment by using their respective environment variables.
How to test the change?
Without the agent running, run any project's test suite with
ddtraceenabled and noticed that there's no warning about Telemetry or Remote Configuration not reaching the agent (because their background workers are not running at all).The same is true for an
irborpryenvironment.