Fix ASM setting for automated user events. #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmarchenko
approved these changes
Aug 23, 2023
TonyCTHsu
approved these changes
Aug 23, 2023
ekump
approved these changes
Aug 23, 2023
GustavoCaso
force-pushed
the
asm-fix-automated-useer-events-settings
branch
from
cd5a830
to
e111282
Compare
The automated user events feature has two settings: enable and mode. Both can be configured via code or using a single ENV var: DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING The corner case found is that setting DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING=extended|safe is disabling automated user events. This PR ensures the enabled setting supports extended and safe as valid values.
GustavoCaso
force-pushed
the
asm-fix-automated-useer-events-settings
branch
from
e111282
to
f73885d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The automated user events feature has two settings:
enableandmodeboth can be configured via code or using a single ENV varDD_APPSEC_AUTOMATED_USER_EVENTS_TRACKINGThe corner case found is that setting
DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING=extended|safeis disabling automated user events.This PR ensures the
enabledsetting supportsextendedandsafeas valid values.Motivation
Additional Notes
How to test the change?