[CIAPP-5371] CI visibility: validate git tags #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3100 +/- ##
==========================================
- Coverage 98.15% 98.15% -0.01%
==========================================
Files 1323 1323
Lines 75048 75068 +20
Branches 3422 3423 +1
==========================================
+ Hits 73665 73684 +19
- Misses 1383 1384 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TonyCTHsu
approved these changes
Sep 4, 2023
| is_expected.to eq( | ||
| { | ||
| 'ci.workspace_path' => "#{Dir.pwd}/spec/datadog/ci/ext/fixtures/git", | ||
| 'git.branch' => env['DD_GIT_BRANCH'], |
There was a problem hiding this comment.
Can we change the assertion with the actual value instead of an indirection through environment variable?
There was a problem hiding this comment.
sorry, I missed your comment :(
I think in this case though it would make it only more magical to put an actual value here as these env vars are defined in the same context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In cases when it is not possible to automatically extract git environment information for CI visibility we allow users to supply this info via environment variables, see docs here.
DD_GIT_REPOSITORY_URL and DD_GIT_COMMIT_SHA are required but currently not validated. When these values are not provided or SHA is not valid CI-APP backend silently drops these traces. End users get no feedback in these cases.
We add the following validations to these tags:
In case these values are incorrect we continue to send traces but we log an error message explaining the problem.
Motivation:
Improve end user experience and prevent confusion when test spans are not shown in UI without any reason.
How to test the change?
Covered by unit tests.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!