Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROF-8289] Upgrade to libdatadog 5 #3169

Merged
merged 9 commits into from
Oct 4, 2023
Merged

[PROF-8289] Upgrade to libdatadog 5 #3169

merged 9 commits into from
Oct 4, 2023

Commits on Oct 4, 2023

  1. Fix libdatadog 5 wants end_timestamp_ns label as an argument to `dd… 

    …og_prof_Profile_add` directly

(Haven't fully tested it since other things aren't compiling yet
either).
    @ivoanjo
    ivoanjo committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    e37523f View commit details
    Browse the repository at this point in the history

  2. Update specs to take into account that libdatadog 5 outputs compresse… 

    …d pprofs
    @ivoanjo
    ivoanjo committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    c3c5961 View commit details
    Browse the repository at this point in the history

  3. Fix libdatadog 5 including reset as part of serialize call 

    This is why the `start_time` argument from `reset` is also needed for
`_serialize`.
    @ivoanjo
    ivoanjo committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    a06c096 View commit details
    Browse the repository at this point in the history

  4. Update to libdatadog 5 ddog_prof_Profile_new returning a result

    @ivoanjo
    ivoanjo committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    09640f7 View commit details
    Browse the repository at this point in the history

  5. Update to libdatadog 5 exporter API 

    In libdatadog 5, the exporter gets two arguments:
* files to be compressed
* files that are already assumed to be compressed

This change matches up with the fact that the libdatadog 5 serializer
now produces compressed pprofs, but some other files (e.g. code
provenance) are still handed over uncompressed.
    @ivoanjo
    ivoanjo committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    e5cd1e7 View commit details
    Browse the repository at this point in the history

  6. Add reminder to be careful with raising exceptions in native object a… 

    …llocators
    @ivoanjo
    ivoanjo committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    a9c823e View commit details
    Browse the repository at this point in the history

  7. Upgrade libdatadog gem dependency to v5.0.0.1.0

    @ivoanjo
    ivoanjo committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    df15be8 View commit details
    Browse the repository at this point in the history

  8. Make Rubocop happy

    @ivoanjo
    ivoanjo committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d56371f View commit details
    Browse the repository at this point in the history

  9. Bump libdatadog version in lockfiles

    @ivoanjo
    ivoanjo committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    87eeec2 View commit details
    Browse the repository at this point in the history