ASM make sure to append content type and length information #3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
appsec
Codecov Report
@@ Coverage Diff @@
## master #3204 +/- ##
==========================================
- Coverage 98.21% 98.21% -0.01%
==========================================
Files 1252 1252
Lines 71937 71988 +51
Branches 3331 3333 +2
==========================================
+ Hits 70654 70701 +47
- Misses 1283 1287 +4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GustavoCaso
changed the title
GustavoCaso
deleted the
asm-make-sure-to-append-content-type-and-length-information
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On ASM, append HTTP request information as part of the top-level span.
The code that collects the request header assumes we are interested in all header requests starting with
HTTP_. Those headers are set by the client following the RFC3875 section 4.1.18Unfortunately, that is not the case for specific headers that are specified by the server. For example,
Content-TypeandContent-Lengthare not prefixed withHTTP_The variables are called CGI server variables. Here is the list
This PR appends the content type and content length information and improves our specs.
Motivation:
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!