Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distributed_tracing option namespacing #3338

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 15, 2023

2.0 Upgrade Guide notes

Programmatic configuration options have been made more consistent with their respective environment variables:

Previous New Environment Variable (unchanged)
tracing.distributed_tracing.propagation_extract_first tracing.propagation_extract_first DD_TRACE_PROPAGATION_EXTRACT_FIRST
tracing.distributed_tracing.propagation_extract_style tracing.propagation_style_extract DD_TRACE_PROPAGATION_STYLE_EXTRACT
tracing.distributed_tracing.propagation_inject_style tracing.propagation_style_inject DD_TRACE_PROPAGATION_STYLE_INJECT
tracing.distributed_tracing.propagation_style tracing.propagation_style DD_TRACE_PROPAGATION_STYLE

Motivation:
Environment variable naming is standard across all Datadog languages.
Our programmatic configuration API is an extra avenue for configuration for Ruby clients, and reflects the same options as the ones provided by environment variables.
The naming between the programmatic variant and the environment variable variant of the same option should be as close as possible.

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added core Involves Datadog core libraries tracing labels Dec 15, 2023
@marcotc marcotc force-pushed the rename-distributed-trace-options branch from 1554aef to 533ebb6 Compare December 19, 2023 20:13
@marcotc marcotc marked this pull request as ready for review December 19, 2023 20:26
@marcotc marcotc requested review from a team as code owners December 19, 2023 20:26
@marcotc marcotc self-assigned this Dec 19, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d67d0a4) 98.11% compared to head (783aa86) 98.12%.
Report is 42 commits behind head on 2.0.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.0    #3338      +/-   ##
==========================================
+ Coverage   98.11%   98.12%   +0.01%     
==========================================
  Files        1250     1243       -7     
  Lines       72401    72014     -387     
  Branches     3391     3376      -15     
==========================================
- Hits        71033    70662     -371     
+ Misses       1368     1352      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcotc marcotc merged commit 49aed7b into 2.0 Jan 26, 2024
151 checks passed
@marcotc marcotc deleted the rename-distributed-trace-options branch January 26, 2024 18:42
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 core Involves Datadog core libraries tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants