-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamically configurable sampling rules #3598
Conversation
Signed-off-by: Marco Costa <marco.costa@datadoghq.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3598 +/- ##
==========================================
- Coverage 98.24% 98.24% -0.01%
==========================================
Files 1255 1255
Lines 74569 74641 +72
Branches 3540 3548 +8
==========================================
+ Hits 73263 73332 +69
- Misses 1306 1309 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I have already compile the changelog for 2.0 in 2.0.0.beta1. Could you add this entry under the [Unreleased] section at Changelog.md.
@TonyCTHsu would you like me to change https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md directly in this PR? |
That is also feasible 🎉 |
What does this PR do?
tracing_sampling_rules
is now provided in the dynamic remote configuration payload, and configures the local trace sampling rules.Also, each sampling rule has a new field, called
provenance
, which allows us to track through the decision-maker tag (_dd.p.dm
) where is sampling decision came from. This even applies for locally configured rules, which get the default value oflocal
provenance.How to test the change?
There are units tests for all changes, plus system tests for integration testing: DataDog/system-tests#2361
Unsure? Have a question? Request a review!