Add sampling rule glob pattern support #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Signed-off-by: Marco Costa <marco.costa@datadoghq.com>
marcotc
commented
Apr 30, 2024
Comment on lines
-53
to
+55
| REMOTE_USER_RULE = '-10' | ||
| REMOTE_USER_RULE = '-11' | ||
| # Dynamically configured rule, automatically generated by Datadog. | ||
| REMOTE_DYNAMIC_RULE = '-11' | ||
| REMOTE_DYNAMIC_RULE = '-12' |
There was a problem hiding this comment.
The RFC was recently changed, and these numbers have been updated.
|
|
||
| # A {Datadog::Tracing::Sampling::Matcher} that allows for arbitrary trace matching | ||
| # based on the return value of a provided block. | ||
| class ProcMatcher < Matcher |
There was a problem hiding this comment.
Arbitrary object matching is not required anymore, that this helper is no longer needed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3616 +/- ##
==========================================
- Coverage 98.12% 98.12% -0.01%
==========================================
Files 1223 1223
Lines 72136 72097 -39
Branches 3425 3424 -1
==========================================
- Hits 70787 70748 -39
Misses 1349 1349 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
approved these changes
May 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for matching sample rules not only by simple strings, but also buy a simple matching pattern. The matching is also case insensitive now.
This brings there will be tracer to parody with other tracing languages.
The following special characters are supported:
?: matches any single character*: matches any substringAdditional Notes:
Support for an arbitrary matcher your object has been removed, given the sampling APIs are now private and does not need such flexibility.
The glob pattern is the same for trace sampling and span sampling, so the code was refractored to share this complex matcher.
How to test the change?
They are unit tests and system tests for this change: DataDog/system-tests#2415