[NO-TICKET] Fix error during telemetry debug logging attempt #3617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the following debug error log that would happen when enabling debug logging + not having an agent running locally.
Specifically, the class used to communicate errors (
Datadog::Core::Telemetry::Http::Response::InternalErrorResponse
) did not define a#code
accessor, thus making the log message that tries to debug the response code fail.Motivation:
Fix this error.
Additional Notes:
The error itself was annoying, but harmless, as we did catch the exception anyway.
I think the current approach of having a
Response
module that then gets inserted into a few classes is a bit error prone.And this is one where we definitely would've been saved by having type signatures for this part of the code.
How to test the change?
I've added unit coverage + you can use the example above to confirm it no longer happens manually.