Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS-7210] Service owners guide #24988

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

[DOCS-7210] Service owners guide #24988

wants to merge 27 commits into from

Conversation

aliciascott
Copy link
Contributor

What does this PR do? What is the motivation?

New Services Owners guide.

  • Purpose of this document is to learn things about what it means to implement Datadog as a Service owner
  • It will address several different audiences , mainly the persona of a service owner - someone who needs to understand the best practices of setting up Datadog to avoid pit-falls down the road

Merge instructions

  • Please merge after reviewing

Additional notes

@aliciascott aliciascott requested review from a team as code owners August 29, 2024 15:47
@aliciascott aliciascott added the WORK IN PROGRESS No review needed, it's a wip ;) label Aug 29, 2024
@github-actions github-actions bot added Images Images are added/removed with this PR Guide Content impacting a guide labels Aug 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 29, 2024 •
edited
Loading

Preview links (active after the build_preview check completes)

New or renamed files

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Sep 4, 2024
@github-actions github-actions bot removed the Guide Content impacting a guide label Sep 5, 2024
dogeahill
dogeahill reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@dogeahill dogeahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions in various places. Overall looks good to me, but I think having some explicit references to our docs, e-books and API would be beneficial

content/en/service_owners_guide/plan.md Show resolved Hide resolved
content/en/service_owners_guide/plan.md Show resolved Hide resolved
content/en/service_owners_guide/plan.md Outdated Show resolved Hide resolved
content/en/service_owners_guide/plan.md Outdated Show resolved Hide resolved
content/en/service_owners_guide/plan.md Outdated Show resolved Hide resolved
content/en/service_owners_guide/build.md Show resolved Hide resolved
content/en/service_owners_guide/build.md Show resolved Hide resolved
content/en/service_owners_guide/build.md Show resolved Hide resolved
content/en/service_owners_guide/run.md Show resolved Hide resolved
content/en/service_owners_guide/run.md Show resolved Hide resolved
rtrieu
rtrieu requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some edits for clarity and consistency. Might do another pass another time.

content/en/service_owners_guide/_index.md Show resolved Hide resolved
content/en/service_owners_guide/_index.md Show resolved Hide resolved
content/en/service_owners_guide/_index.md Show resolved Hide resolved
content/en/service_owners_guide/_index.md Show resolved Hide resolved
content/en/service_owners_guide/_index.md Show resolved Hide resolved
content/en/service_owners_guide/plan.md Show resolved Hide resolved
content/en/service_owners_guide/run.md Outdated Show resolved Hide resolved
content/en/service_owners_guide/plan.md Show resolved Hide resolved
content/en/service_owners_guide/build.md Show resolved Hide resolved
content/en/service_owners_guide/run.md Outdated Show resolved Hide resolved
aliciascott and others added 3 commits October 3, 2024 09:23
@aliciascott @rtrieu
Apply suggestions from code review
83617e0 
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
@aliciascott
updates from review
8251c5b
@aliciascott
a few more additions and fixing link
9d36072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogeahill dogeahill dogeahill left review comments

@rtrieu rtrieu Awaiting requested review from rtrieu

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend Images Images are added/removed with this PR WORK IN PROGRESS No review needed, it's a wip ;)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliciascott @rtrieu @dogeahill