Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROF-8139] Package libdatadog v4.0.0 for Ruby #238

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Sep 4, 2023

What does this PR do?

This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README:
https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg

Motivation

Enable Ruby to use libdatadog v4.0.0.

Additional Notes

N/A

How to test the change?

I've tested this release locally against the changes in DataDog/dd-trace-rb#3104 .

As a reminder, new libdatadog releases don't get automatically picked up by Ruby, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.

For Reviewers

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

This PR actually touches code that publishes builds (updates the SHAs to match the new releases), but I don't think we need a review from security for this.

**What does this PR do?**

This PR includes the changes documented in the "Releasing a new version
to rubygems.org" part of the README:
<https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg>

**Motivation:**

Enable Ruby to use libdatadog v4.0.0.

**Additional Notes:**

N/A

**How to test the change?**

I've tested this release locally against the changes in DataDog/dd-trace-rb#3104 .

As a reminder, new libdatadog releases don't get automatically picked up by Ruby, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
@ivoanjo ivoanjo requested a review from a team as a code owner September 4, 2023 09:49
@ivoanjo ivoanjo changed the title Package libdatadog v4.0.0 for Ruby [PROF-8139] Package libdatadog v4.0.0 for Ruby Sep 4, 2023
Copy link
Member

@realFlowControl realFlowControl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivoanjo ivoanjo merged commit acd698a into main Sep 4, 2023
30 checks passed
@morrisonlevi morrisonlevi deleted the ivoanjo/prof-8139-libdatadog4-ruby branch September 5, 2023 16:43
ivoanjo added a commit that referenced this pull request Oct 4, 2023
**What does this PR do?**

This PR includes the changes documented in the "Releasing a new version
to rubygems.org" part of the README:
<https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg>

(It's also exactly the same as
[the v4.0.0 release PR](#238)).

**Motivation:**

Enable Ruby to use libdatadog v5.0.0.

**Additional Notes:**

N/A

**How to test the change?**

I've tested this release locally against the changes in
DataDog/dd-trace-rb#3169 .

As a reminder, new libdatadog releases don't get automatically picked up
by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this
release against all supported Ruby versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants