Use Cargo workspace properties and document MSRV #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't bump it, although based on how often we've bumped in the past, we could move to Rust 1.71.
morrisonlevi
force-pushed
the
levi/document-msrv
branch
from
b947020
to
8ea3f16
Compare
|
Thanks for picking this up! I think it makes a lot of sense (with my extremely limited Rust-foo, lol). I did notice that CI is breaking because some of our images are not yet on Rust 1.69. |
pawelchcki
previously approved these changes
Sep 13, 2023
danielsn
previously approved these changes
Sep 13, 2023
morrisonlevi
dismissed stale reviews from danielsn and pawelchcki
via
d64cfb2
thedavl
approved these changes
Sep 14, 2023
I fixed the Alpine images in the downstream repository 👍🏻 |
ivoanjo
added a commit
that referenced
this pull request
Oct 3, 2023
**What does this PR do?** This PR bumps the libdatadog version to 5.0.0. This PR looks a bit different from previous PRs to bump libdatadog version [(here's the 4.0.0 PR as an example)](#236) because in [this PR](#247) we've centralized the version on the single `Cargo.toml` file. Furthermore, we're going from 4.0.0 to 5.0.0 because there were a number of backwards-incompatible changes to the profiling APIs. **Motivation:** Release libdatadog 5.5.0. **Additional Notes:** If I haven't missed anything, the backwards incompatible API changes were the following: * The value of the `end_timestamp_ns` label is now provided as a regular argument to `ddog_prof_Profile_add` * The libdatadog 5 serializer outputs compressed pprof files * The exporter has a new API that takes two lists, a list of files to compress and a list of files to assume are compressed when exporting * The libdatadog 5 serializer now resets profiles as part of serializing them * The `ddog_prof_Profile_new` now returns a result structure **How to test the change?** I've tested the libdatadog 5 releases using the Ruby profiler, see DataDog/dd-trace-rb#3169 for my draft PR.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds
workspace.packageto the rootCargo.toml:Motivation
This allows changing things in fewer places. I hope to make changing the minimum supported rust version (MSRV), edition, and libdatadog version easier.
Additional Notes
Not every crate inherits these new properties. The serverless and sidecar crates, and some of their dependencies, have remained under their own versioning and control.
How to test the change?
Regular tests should apply. This shouldn't change any behavior.
For Reviewers
@DataDog/security-design-and-guidance.