Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package libdatadog 0.8.0 for Ruby #44

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Aug 24, 2022

What does this PR do?

  • Update the needed versions and hashes to package libdatadog 0.8.0 for Ruby
  • Updates a few hardcoded file names to the new names adopted for 0.8.0

I'm following along the checklist at
https://github.com/DataDog/libdatadog/blob/main/ruby/README.md#releasing-a-new-version-to-rubygemsorg.

Motivation

Use latest release for Ruby profiling.

How to test the change?

I've gone ahead and updated the Ruby profiler to use this version in https://github.com/DataDog/dd-trace-rb/tree/ivoanjo/upgrade-to-libdatadog-0.8.0 . I am able to run the Ruby profiler test suite both on macOS as well as on Linux with the new release.

To reproduce my results, you need to do the following:

  • Check out this PR
  • Build the packages locally: cd ruby && bundle exec rake package
  • Check out dd-trace-rb
  • Change to the branch I mentioned above
  • Copy the ruby/pkg/libdatadog-0.8.0.1.0.gem that is generated by packaging to the root of the dd-trace-rb repository
  • Open the dd-trace-rb docker dev environment: docker-compose run --rm tracer-2.7 /bin/bash
  • Manually install the gem: gem install libdatadog-0.8.0.1.0.gem
  • Install other dependencies: bundle install
  • Run the profiler test suite: bundle exec rake clean compile && bundle exec rspec spec/datadog/profiling

Copy link
Contributor

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observation checklist:

  • Updates hashes
  • Refactors variable names
  • References to ddprof_ffi_with_rpath are changed to datadog_profiling_with_rpath

I didn't check the hashes, but otherwise LGTM!

@ivoanjo ivoanjo merged commit 38d69b5 into main Aug 30, 2022
@ivoanjo ivoanjo deleted the ivoanjo/package-0.8.0-for-ruby branch August 30, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants