Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up to 12.0.0 in preparation for a new release #574

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Bump up to 12.0.0 in preparation for a new release #574

merged 1 commit into from
Aug 5, 2024

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Aug 5, 2024 •
edited
Loading

What does this PR do?

There was a breaking change in one of the profiling APIs, so bumping up to 12.0.0 from 11.0.0, se below for an example.

Motivation

Would like to use #538 from dd-trace-py

Additional Notes

ddog_prof_Exporter_Request_build @ 11.0.0

pub unsafe extern "C" fn ddog_prof_Exporter_Request_build(
    exporter: Option<&mut ProfileExporter>,
    start: Timespec,
    end: Timespec,
    files_to_compress_and_export: Slice<File>,
    files_to_export_unmodified: Slice<File>,
    optional_additional_tags: Option<&ddcommon_ffi::Vec<Tag>>,
    optional_endpoints_stats: Option<&ProfiledEndpointsStats>,
    optional_internal_metadata_json: Option<&CharSlice>,
    optional_info_json: Option<&CharSlice>,
    timeout_ms: u64,
) -> RequestBuildResult {

A main HEAD

pub unsafe extern "C" fn ddog_prof_Exporter_Request_build(
    exporter: Option<&mut ProfileExporter>,
    start: Timespec,
    end: Timespec,
    files_to_compress_and_export: Slice<File>,
    files_to_export_unmodified: Slice<File>,
    optional_additional_tags: Option<&ddcommon_ffi::Vec<Tag>>,
    optional_endpoints_stats: Option<&ProfiledEndpointsStats>,
    optional_internal_metadata_json: Option<&CharSlice>,
    optional_info_json: Option<&CharSlice>,
) -> RequestBuildResult {

How to test the change?

Describe here in detail how the change can be validated.

@taegyunkim taegyunkim requested a review from a team as a code owner August 5, 2024 13:47
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.44%. Comparing base (1d4b6b8) to head (24a130d).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
+ Coverage   70.39%   70.44%   +0.04%     
==========================================
  Files         214      214              
  Lines       28901    28884      -17     
==========================================
  Hits        20346    20346              
+ Misses       8555     8538      -17
Components Coverage Δ
crashtracker 21.20% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 50.00% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.07% <ø> (ø)
ddcommon-ffi 70.20% <ø> (ø)
ddtelemetry 58.95% <ø> (ø)
ipc 84.18% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 34.55% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.87% <ø> (ø)
trace-mini-agent 70.88% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.16% <ø> (ø)
trace-utils 92.38% <ø> (+0.57%) ⬆️

@pr-commenter
Copy link

pr-commenter bot commented Aug 5, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-08-05 15:52:40

Comparing candidate commit 24a130d in PR branch taegyunkim/12.0.0-release with baseline commit 1d4b6b8 in branch main.

Found 3 performance improvements and 9 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/

  • 🟥 execution_time [+0.164ns; +0.170ns] or [+4.783%; +4.962%]
  • 🟥 throughput [-13819248.703op/s; -13299291.988op/s] or [-4.736%; -4.558%]

scenario:credit_card/is_card_number/37828224631

  • 🟥 execution_time [+0.165ns; +0.172ns] or [+4.800%; +5.031%]
  • 🟥 throughput [-14002012.413op/s; -13327584.872op/s] or [-4.799%; -4.568%]

scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...

  • 🟩 execution_time [-10.972ns; -9.995ns] or [-3.893%; -3.547%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟥 execution_time [+3.261ns; +3.347ns] or [+14.918%; +15.311%]

scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...

  • 🟥 execution_time [+64.781ns; +66.752ns] or [+10.942%; +11.275%]

scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters

  • 🟥 execution_time [+30.281ns; +31.501ns] or [+14.966%; +15.569%]

scenario:normalization/normalize_service/normalize_service/test_ASCII

  • 🟥 execution_time [+6.369ns; +8.414ns] or [+9.138%; +12.071%]

scenario:redis/obfuscate_redis_string

  • 🟩 execution_time [-1.068µs; -1.031µs] or [-2.835%; -2.736%]

scenario:sql/obfuscate_sql_string

  • 🟩 execution_time [-2.558µs; -2.519µs] or [-3.617%; -3.562%]

scenario:tags/replace_trace_tags

  • 🟥 execution_time [+60.508ns; +62.544ns] or [+2.675%; +2.765%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 24a130d 1722872268 taegyunkim/12.0.0-release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.503ns 3.594ns ± 0.014ns 3.600ns ± 0.003ns 3.602ns 3.604ns 3.605ns 3.612ns 0.33% -2.974 11.757 0.40% 0.001ns 1 200
credit_card/is_card_number/ throughput 276884820.528op/s 278224476.478op/s ± 1121384.531op/s 277786113.249op/s ± 225841.521op/s 278193374.669op/s 280208868.204op/s 281960765.645op/s 285432091.396op/s 2.75% 3.034 12.295 0.40% 79293.861op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 85.066ns 87.110ns ± 0.851ns 87.086ns ± 0.518ns 87.545ns 88.294ns 90.163ns 91.408ns 4.96% 1.208 4.365 0.97% 0.060ns 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10939945.177op/s 11480838.058op/s ± 110905.003op/s 11482941.103op/s ± 68321.529op/s 11553908.141op/s 11629280.106op/s 11722532.592op/s 11755627.531op/s 2.37% -1.070 3.770 0.96% 7842.168op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 80.119ns 82.433ns ± 0.784ns 82.326ns ± 0.450ns 82.896ns 83.877ns 84.290ns 84.446ns 2.58% 0.174 0.175 0.95% 0.055ns 1 200
credit_card/is_card_number/ 378282246310005 throughput 11841823.704op/s 12132091.883op/s ± 115282.051op/s 12146757.889op/s ± 66008.536op/s 12201399.114op/s 12326154.629op/s 12412624.974op/s 12481384.142op/s 2.75% -0.112 0.195 0.95% 8151.672op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.299ns 3.596ns ± 0.023ns 3.600ns ± 0.003ns 3.602ns 3.604ns 3.607ns 3.647ns 1.30% -10.516 130.282 0.65% 0.002ns 1 200
credit_card/is_card_number/37828224631 throughput 274193323.066op/s 278123015.448op/s ± 1939173.129op/s 277766929.608op/s ± 201495.572op/s 278107584.878op/s 279328122.850op/s 281616559.644op/s 303158005.521op/s 9.14% 10.936 137.674 0.70% 137120.247op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 77.406ns 79.945ns ± 0.754ns 79.960ns ± 0.443ns 80.407ns 81.008ns 81.662ns 82.773ns 3.52% -0.282 1.547 0.94% 0.053ns 1 200
credit_card/is_card_number/378282246310005 throughput 12081223.799op/s 12509737.622op/s ± 118368.954op/s 12506216.121op/s ± 69209.424op/s 12574403.347op/s 12736789.163op/s 12829052.843op/s 12918833.315op/s 3.30% 0.380 1.577 0.94% 8369.949op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 66.976ns 68.060ns ± 0.408ns 68.096ns ± 0.222ns 68.285ns 68.562ns 69.033ns 70.287ns 3.22% 0.579 4.969 0.60% 0.029ns 1 200
credit_card/is_card_number/37828224631000521389798 throughput 14227337.718op/s 14693471.683op/s ± 87852.466op/s 14685228.144op/s ± 48024.151op/s 14742804.234op/s 14834852.039op/s 14930443.716op/s 14930819.174op/s 1.67% -0.464 4.509 0.60% 6212.107op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 21.201ns 22.493ns ± 0.455ns 22.468ns ± 0.230ns 22.716ns 23.231ns 23.462ns 24.641ns 9.67% 0.376 2.878 2.02% 0.032ns 1 200
credit_card/is_card_number/x371413321323331 throughput 40582581.261op/s 44475590.600op/s ± 895238.154op/s 44508698.668op/s ± 457743.982op/s 44931282.940op/s 45774115.915op/s 47167216.278op/s 47168162.045op/s 5.98% -0.101 2.417 2.01% 63302.897op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.264ns 3.429ns ± 0.016ns 3.431ns ± 0.000ns 3.431ns 3.432ns 3.437ns 3.450ns 0.56% -9.662 92.821 0.48% 0.001ns 1 200
credit_card/is_card_number_no_luhn/ throughput 289836707.773op/s 291608390.396op/s ± 1460296.138op/s 291473522.904op/s ± 41986.168op/s 291519551.435op/s 291595449.485op/s 291955483.038op/s 306384003.651op/s 5.12% 9.682 93.079 0.50% 103258.530op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 66.969ns 69.071ns ± 0.480ns 69.024ns ± 0.262ns 69.330ns 69.837ns 70.207ns 70.686ns 2.41% -0.025 1.984 0.69% 0.034ns 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14147031.828op/s 14478480.370op/s ± 100682.277op/s 14487784.795op/s ± 55279.137op/s 14534225.497op/s 14618663.901op/s 14736534.137op/s 14932354.236op/s 3.07% 0.110 2.140 0.69% 7119.312op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 62.227ns 64.370ns ± 0.526ns 64.406ns ± 0.267ns 64.668ns 65.020ns 65.337ns 67.492ns 4.79% 0.372 6.836 0.82% 0.037ns 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14816536.424op/s 15536263.855op/s ± 126726.740op/s 15526517.182op/s ± 64362.962op/s 15597283.034op/s 15738690.399op/s 15890620.780op/s 16070317.696op/s 3.50% -0.167 6.128 0.81% 8960.934op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.264ns 3.429ns ± 0.016ns 3.431ns ± 0.000ns 3.431ns 3.433ns 3.434ns 3.447ns 0.47% -9.711 93.402 0.48% 0.001ns 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 290118640.338op/s 291607761.997op/s ± 1460064.081op/s 291472336.615op/s ± 37896.006op/s 291509445.773op/s 291595251.012op/s 291977736.565op/s 306398857.317op/s 5.12% 9.727 93.602 0.50% 103242.121op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 60.338ns 61.895ns ± 0.520ns 61.904ns ± 0.314ns 62.193ns 62.788ns 63.041ns 63.185ns 2.07% -0.020 0.166 0.84% 0.037ns 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15826472.461op/s 16157403.695op/s ± 135920.123op/s 16153930.210op/s ± 82465.190op/s 16249046.235op/s 16354944.214op/s 16518825.525op/s 16573239.033op/s 2.60% 0.075 0.210 0.84% 9611.004op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 66.783ns 67.753ns ± 0.340ns 67.778ns ± 0.174ns 67.923ns 68.271ns 68.661ns 69.249ns 2.17% 0.176 2.280 0.50% 0.024ns 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 14440626.143op/s 14759820.633op/s ± 73927.258op/s 14753964.922op/s ± 37968.338op/s 14800590.664op/s 14905173.551op/s 14939234.266op/s 14973954.790op/s 1.49% -0.113 2.172 0.50% 5227.447op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 21.324ns 22.287ns ± 0.383ns 22.285ns ± 0.232ns 22.517ns 22.840ns 23.294ns 23.795ns 6.77% 0.423 1.367 1.72% 0.027ns 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 42026491.901op/s 44882246.888op/s ± 767672.691op/s 44873372.704op/s ± 467764.133op/s 45347304.847op/s 46231260.185op/s 46637022.642op/s 46895757.869op/s 4.51% -0.265 1.042 1.71% 54282.657op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.592ns; 3.596ns] or [-0.055%; +0.055%] None None None
credit_card/is_card_number/ throughput [278069063.367op/s; 278379889.589op/s] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [86.992ns; 87.228ns] or [-0.135%; +0.135%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [11465467.691op/s; 11496208.425op/s] or [-0.134%; +0.134%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [82.325ns; 82.542ns] or [-0.132%; +0.132%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12116114.900op/s; 12148068.867op/s] or [-0.132%; +0.132%] None None None
credit_card/is_card_number/37828224631 execution_time [3.592ns; 3.599ns] or [-0.090%; +0.090%] None None None
credit_card/is_card_number/37828224631 throughput [277854264.703op/s; 278391766.194op/s] or [-0.097%; +0.097%] None None None
credit_card/is_card_number/378282246310005 execution_time [79.840ns; 80.049ns] or [-0.131%; +0.131%] None None None
credit_card/is_card_number/378282246310005 throughput [12493332.823op/s; 12526142.420op/s] or [-0.131%; +0.131%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [68.003ns; 68.116ns] or [-0.083%; +0.083%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [14681296.176op/s; 14705647.190op/s] or [-0.083%; +0.083%] None None None
credit_card/is_card_number/x371413321323331 execution_time [22.430ns; 22.556ns] or [-0.280%; +0.280%] None None None
credit_card/is_card_number/x371413321323331 throughput [44351519.202op/s; 44599661.998op/s] or [-0.279%; +0.279%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.427ns; 3.432ns] or [-0.066%; +0.066%] None None None
credit_card/is_card_number_no_luhn/ throughput [291406007.396op/s; 291810773.396op/s] or [-0.069%; +0.069%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [69.005ns; 69.138ns] or [-0.096%; +0.096%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14464526.774op/s; 14492433.965op/s] or [-0.096%; +0.096%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [64.297ns; 64.443ns] or [-0.113%; +0.113%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15518700.747op/s; 15553826.962op/s] or [-0.113%; +0.113%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.427ns; 3.432ns] or [-0.066%; +0.066%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [291405411.158op/s; 291810112.836op/s] or [-0.069%; +0.069%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [61.823ns; 61.968ns] or [-0.117%; +0.117%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16138566.473op/s; 16176240.916op/s] or [-0.117%; +0.117%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [67.706ns; 67.800ns] or [-0.069%; +0.069%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [14749575.026op/s; 14770066.240op/s] or [-0.069%; +0.069%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [22.234ns; 22.340ns] or [-0.238%; +0.238%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [44775854.837op/s; 44988638.940op/s] or [-0.237%; +0.237%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 24a130d 1722872268 taegyunkim/12.0.0-release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.307µs 2.323µs ± 0.006µs 2.323µs ± 0.005µs 2.329µs 2.331µs 2.333µs 2.342µs 0.83% -0.692 0.616 0.27% 0.000µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.322µs; 2.324µs] or [-0.038%; +0.038%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 24a130d 1722872268 taegyunkim/12.0.0-release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 321.501ns 331.988ns ± 6.460ns 330.660ns ± 4.566ns 335.899ns 340.578ns 343.072ns 378.646ns 14.51% 2.117 12.564 1.94% 0.457ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [331.093ns; 332.884ns] or [-0.270%; +0.270%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 24a130d 1722872268 taegyunkim/12.0.0-release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.635µs 1.638µs ± 0.001µs 1.638µs ± 0.000µs 1.638µs 1.638µs 1.639µs 1.643µs 0.33% 2.108 24.292 0.04% 0.000µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.638µs; 1.638µs] or [-0.006%; +0.006%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 24a130d 1722872268 taegyunkim/12.0.0-release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.285µs 37.274µs ± 31.538µs 37.696µs ± 3.145µs 40.174µs 50.882µs 74.467µs 450.435µs 1094.91% 11.350 145.909 84.40% 2.230µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [32.903µs; 41.645µs] or [-11.726%; +11.726%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 24a130d 1722872268 taegyunkim/12.0.0-release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.410µs 2.929µs ± 1.553µs 2.793µs ± 0.022µs 2.815µs 2.980µs 3.884µs 19.202µs 587.47% 9.597 92.737 52.90% 0.110µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.714µs; 3.144µs] or [-7.349%; +7.349%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 24a130d 1722872268 taegyunkim/12.0.0-release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 265.703ns 271.320ns ± 3.502ns 270.748ns ± 2.008ns 272.864ns 277.060ns 284.435ns 285.189ns 5.33% 1.521 3.339 1.29% 0.248ns 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 33.613ns 34.898ns ± 0.297ns 34.909ns ± 0.140ns 35.077ns 35.279ns 35.489ns 35.880ns 2.78% -0.946 2.917 0.85% 0.021ns 1 200
normalization/normalize_name/normalize_name/good execution_time 24.408ns 25.167ns ± 0.273ns 25.181ns ± 0.145ns 25.299ns 25.644ns 26.015ns 26.053ns 3.46% 0.214 1.519 1.08% 0.019ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [270.835ns; 271.805ns] or [-0.179%; +0.179%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [34.857ns; 34.940ns] or [-0.118%; +0.118%] None None None
normalization/normalize_name/normalize_name/good execution_time [25.129ns; 25.204ns] or [-0.150%; +0.150%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 24a130d 1722872268 taegyunkim/12.0.0-release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.937µs 68.194µs ± 0.092µs 68.185µs ± 0.042µs 68.230µs 68.308µs 68.391µs 69.070µs 1.30% 4.444 40.647 0.13% 0.006µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [68.181µs; 68.207µs] or [-0.019%; +0.019%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 24a130d 1722872268 taegyunkim/12.0.0-release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 36.527µs 36.610µs ± 0.120µs 36.598µs ± 0.023µs 36.621µs 36.651µs 36.702µs 38.009µs 3.86% 9.663 102.200 0.33% 0.008µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [36.594µs; 36.627µs] or [-0.045%; +0.045%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 24a130d 1722872268 taegyunkim/12.0.0-release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 134.873µs 135.556µs ± 0.218µs 135.522µs ± 0.097µs 135.631µs 135.908µs 136.220µs 136.804µs 0.95% 2.063 8.356 0.16% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [135.525µs; 135.586µs] or [-0.022%; +0.022%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 24a130d 1722872268 taegyunkim/12.0.0-release
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 655.928ns 657.793ns ± 0.640ns 657.720ns ± 0.245ns 658.018ns 658.506ns 659.326ns 663.643ns 0.90% 4.303 36.222 0.10% 0.045ns 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 445.160ns 447.266ns ± 1.283ns 446.953ns ± 0.456ns 447.487ns 450.586ns 452.082ns 453.087ns 1.37% 2.056 4.988 0.29% 0.091ns 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 230.254ns 233.224ns ± 2.017ns 234.325ns ± 1.267ns 234.962ns 235.656ns 236.480ns 237.447ns 1.33% -0.129 -1.662 0.86% 0.143ns 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.074ns 43.216ns ± 7.123ns 39.884ns ± 2.243ns 46.289ns 58.760ns 59.373ns 59.705ns 49.70% 1.363 0.495 16.44% 0.504ns 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 72.380ns 77.092ns ± 4.597ns 75.413ns ± 0.478ns 83.512ns 84.928ns 85.395ns 85.593ns 13.50% 0.906 -0.829 5.95% 0.325ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [657.704ns; 657.882ns] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [447.088ns; 447.444ns] or [-0.040%; +0.040%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [232.945ns; 233.504ns] or [-0.120%; +0.120%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [42.229ns; 44.204ns] or [-2.284%; +2.284%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [76.455ns; 77.729ns] or [-0.826%; +0.826%] None None None

Baseline

Omitted due to size.

ivoanjo
ivoanjo approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@taegyunkim taegyunkim merged commit 737c1f2 into main Aug 5, 2024
33 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/12.0.0-release branch August 5, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoanjo ivoanjo ivoanjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taegyunkim @codecov-commenter @ivoanjo