Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log file and disable LSAN usage in sidecar #602

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Fix log file and disable LSAN usage in sidecar #602

merged 5 commits into from
Aug 29, 2024

Conversation

bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Aug 28, 2024

  • Sidecar will leak some global structures, using LSAN there would either require an extensive suppressions list. For now we just opt to disable it. This avoids false positives in our testing we have to manually detect and ignore.
  • Using an invalid log file should simply avoid sending it to the sidecar completely instead of failing there again, preventing two log messages for the same issue.
  • Use _exit(0) instead of regular exit(0) when daemonizing to avoid sideeffects from atexit() handlers inherited from forking.

Like leak sanitizer running here; we definitely do not have cleaned up anything at this point.
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi requested review from a team as code owners August 28, 2024 13:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.83%. Comparing base (d910738) to head (2734124).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
- Coverage   72.84%   72.83%   -0.01%     
==========================================
  Files         243      243              
  Lines       34681    34683       +2     
==========================================
  Hits        25263    25263              
- Misses       9418     9420       +2     
Components Coverage Δ
crashtracker 20.44% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.12% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 82.11% <ø> (ø)
ddcommon-ffi 68.11% <ø> (ø)
ddtelemetry 59.02% <ø> (ø)
ipc 84.00% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.15% <0.00%> (-0.04%) ⬇️
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <0.00%> (+0.18%) ⬆️
tinybytes 91.66% <ø> (ø)
trace-mini-agent 70.88% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.00% <ø> (ø)

@pr-commenter
Copy link

pr-commenter bot commented Aug 28, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-08-29 15:13:08

Comparing candidate commit 2734124 in PR branch bob/fix-lsan with baseline commit d910738 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2734124 1724943806 bob/fix-lsan
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 310.348µs 314.242µs ± 0.850µs 314.326µs ± 0.528µs 314.793µs 315.539µs 315.759µs 315.957µs 0.52% -0.943 2.391 0.27% 0.060µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3164983.788op/s 3182282.506op/s ± 8632.114op/s 3181413.109op/s ± 5358.163op/s 3186852.031op/s 3196109.503op/s 3207364.871op/s 3222190.083op/s 1.28% 0.972 2.498 0.27% 610.383op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.962µs 28.036µs ± 0.040µs 28.028µs ± 0.022µs 28.062µs 28.103µs 28.138µs 28.201µs 0.62% 0.803 0.779 0.14% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 35459372.765op/s 35668775.231op/s ± 50372.871op/s 35677988.997op/s ± 27692.199op/s 35703609.578op/s 35742007.870op/s 35753218.173op/s 35762316.765op/s 0.24% -0.794 0.751 0.14% 3561.900op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.718µs 16.756µs ± 0.042µs 16.736µs ± 0.006µs 16.747µs 16.856µs 16.870µs 16.897µs 0.96% 1.653 1.389 0.25% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 59181717.463op/s 59681073.447op/s ± 150644.337op/s 59750496.113op/s ± 22267.814op/s 59768193.115op/s 59784578.434op/s 59798257.709op/s 59814979.090op/s 0.11% -1.648 1.368 0.25% 10652.163op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [314.124µs; 314.360µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3181086.178op/s; 3183478.834op/s] or [-0.038%; +0.038%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [28.030µs; 28.041µs] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [35661794.035op/s; 35675756.426op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.750µs; 16.762µs] or [-0.035%; +0.035%] None None None
normalization/normalize_name/normalize_name/good throughput [59660195.591op/s; 59701951.304op/s] or [-0.035%; +0.035%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2734124 1724943806 bob/fix-lsan
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 137.074µs 137.700µs ± 0.218µs 137.678µs ± 0.128µs 137.814µs 138.122µs 138.296µs 138.502µs 0.60% 0.597 0.975 0.16% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [137.670µs; 137.730µs] or [-0.022%; +0.022%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2734124 1724943806 bob/fix-lsan
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.147µs 23.392µs ± 14.590µs 17.505µs ± 0.130µs 17.720µs 52.959µs 56.249µs 129.035µs 637.13% 3.540 17.328 62.22% 1.032µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [21.370µs; 25.414µs] or [-8.644%; +8.644%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2734124 1724943806 bob/fix-lsan
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 73.850µs 73.984µs ± 0.150µs 73.960µs ± 0.040µs 74.001µs 74.164µs 74.271µs 75.695µs 2.35% 7.905 83.970 0.20% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [73.963µs; 74.005µs] or [-0.028%; +0.028%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2734124 1724943806 bob/fix-lsan
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 302.167ns 314.027ns ± 13.627ns 306.657ns ± 3.553ns 322.161ns 342.916ns 353.097ns 366.230ns 19.43% 1.520 1.745 4.33% 0.964ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [312.139ns; 315.916ns] or [-0.601%; +0.601%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2734124 1724943806 bob/fix-lsan
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.421µs 2.958µs ± 1.432µs 2.794µs ± 0.021µs 2.814µs 3.050µs 12.941µs 16.266µs 482.16% 7.960 63.567 48.30% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.760µs; 3.157µs] or [-6.711%; +6.711%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2734124 1724943806 bob/fix-lsan
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 618.474µs 619.247µs ± 0.464µs 619.160µs ± 0.228µs 619.428µs 620.102µs 620.584µs 622.794µs 0.59% 2.841 16.608 0.07% 0.033µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1605666.676op/s 1614865.398op/s ± 1206.428op/s 1615091.327op/s ± 594.134op/s 1615611.721op/s 1616181.215op/s 1616552.646op/s 1616883.018op/s 0.11% -2.818 16.374 0.07% 85.307op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 385.714µs 388.659µs ± 1.004µs 388.529µs ± 0.714µs 389.457µs 390.305µs 391.022µs 391.265µs 0.70% 0.123 -0.204 0.26% 0.071µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2555815.526op/s 2572969.316op/s ± 6643.077op/s 2573807.589op/s ± 4720.156op/s 2577763.131op/s 2582057.427op/s 2587266.847op/s 2592597.568op/s 0.73% -0.109 -0.203 0.26% 469.737op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 190.932µs 191.583µs ± 0.224µs 191.603µs ± 0.140µs 191.731µs 191.935µs 192.035µs 192.124µs 0.27% -0.382 0.003 0.12% 0.016µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5204978.041op/s 5219668.933op/s ± 6110.455op/s 5219136.835op/s ± 3803.406op/s 5223481.465op/s 5230630.539op/s 5234926.544op/s 5237475.182op/s 0.35% 0.389 0.008 0.12% 432.074op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 45.056µs 45.242µs ± 0.071µs 45.240µs ± 0.053µs 45.294µs 45.361µs 45.404µs 45.416µs 0.39% 0.040 -0.279 0.16% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22018484.833op/s 22103618.840op/s ± 34631.568op/s 22104290.569op/s ± 25740.127op/s 22128173.100op/s 22156030.394op/s 22174984.390op/s 22194443.938op/s 0.41% -0.031 -0.280 0.16% 2448.822op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.149µs 49.704µs ± 0.329µs 49.591µs ± 0.200µs 49.925µs 50.346µs 50.407µs 50.531µs 1.90% 0.710 -0.605 0.66% 0.023µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19789727.245op/s 20119884.931op/s ± 132660.510op/s 20164866.542op/s ± 81775.262op/s 20216490.403op/s 20280652.408op/s 20310613.808op/s 20346202.464op/s 0.90% -0.692 -0.628 0.66% 9380.515op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [619.183µs; 619.311µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1614698.199op/s; 1615032.598op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [388.519µs; 388.798µs] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2572048.650op/s; 2573889.983op/s] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [191.552µs; 191.614µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5218822.083op/s; 5220515.783op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [45.232µs; 45.251µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22098819.237op/s; 22108418.442op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.659µs; 49.750µs] or [-0.092%; +0.092%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20101499.460op/s; 20138270.402op/s] or [-0.091%; +0.091%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2734124 1724943806 bob/fix-lsan
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.948µs 39.653µs ± 1.218µs 39.118µs ± 0.104µs 39.228µs 42.307µs 42.349µs 42.709µs 9.18% 1.680 0.884 3.06% 0.086µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [39.485µs; 39.822µs] or [-0.426%; +0.426%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2734124 1724943806 bob/fix-lsan
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 1.612µs 1.613µs ± 0.000µs 1.613µs ± 0.000µs 1.614µs 1.614µs 1.614µs 1.615µs 0.12% 0.503 0.299 0.03% 0.000µs 1 200
credit_card/is_card_number/ throughput 619067313.206op/s 619780043.901op/s ± 184194.411op/s 619796657.289op/s ± 128964.641op/s 619924614.186op/s 620038569.063op/s 620133459.025op/s 620156062.769op/s 0.06% -0.501 0.295 0.03% 13024.512op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 104.285µs 105.493µs ± 1.024µs 105.045µs ± 0.306µs 105.965µs 107.454µs 108.069µs 109.379µs 4.13% 1.269 0.495 0.97% 0.072µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 9142527.141op/s 9480151.387op/s ± 90918.529op/s 9519773.536op/s ± 27809.302op/s 9541601.113op/s 9561404.842op/s 9569920.136op/s 9589062.715op/s 0.73% -1.244 0.394 0.96% 6428.911op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 96.475µs 97.240µs ± 0.442µs 97.168µs ± 0.193µs 97.363µs 98.071µs 98.771µs 99.561µs 2.46% 2.014 5.854 0.45% 0.031µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 10044122.954op/s 10284000.914op/s ± 46339.319op/s 10291494.082op/s ± 20402.070op/s 10310803.159op/s 10337447.616op/s 10346561.407op/s 10365368.158op/s 0.72% -1.963 5.585 0.45% 3276.685op/s 1 200
credit_card/is_card_number/37828224631 execution_time 1.613µs 1.614µs ± 0.003µs 1.613µs ± 0.000µs 1.614µs 1.614µs 1.615µs 1.658µs 2.73% 13.117 177.323 0.20% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 603295439.295op/s 619682532.607op/s ± 1193659.685op/s 619791629.434op/s ± 139367.116op/s 619921945.246op/s 620056567.388op/s 620141919.843op/s 620144647.063op/s 0.06% -13.074 176.487 0.19% 84404.486op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 94.160µs 95.344µs ± 0.686µs 95.231µs ± 0.485µs 95.778µs 96.673µs 97.032µs 97.339µs 2.21% 0.681 -0.059 0.72% 0.049µs 1 200
credit_card/is_card_number/378282246310005 throughput 10273340.642op/s 10488869.906op/s ± 75108.506op/s 10500740.185op/s ± 53552.050op/s 10549755.000op/s 10592512.789op/s 10602485.491op/s 10620204.940op/s 1.14% -0.649 -0.116 0.71% 5310.973op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 94.090µs 94.755µs ± 0.443µs 94.722µs ± 0.336µs 95.060µs 95.454µs 95.746µs 97.526µs 2.96% 1.455 6.186 0.47% 0.031µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 10253715.618op/s 10553758.068op/s ± 49047.891op/s 10557198.480op/s ± 37361.255op/s 10594294.179op/s 10615260.503op/s 10624489.864op/s 10628092.173op/s 0.67% -1.373 5.568 0.46% 3468.210op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 22.434µs 22.767µs ± 0.204µs 22.749µs ± 0.143µs 22.907µs 23.141µs 23.257µs 23.334µs 2.57% 0.389 -0.489 0.89% 0.014µs 1 200
credit_card/is_card_number/x371413321323331 throughput 42855433.102op/s 43927511.684op/s ± 391459.622op/s 43957512.943op/s ± 278686.757op/s 44220471.471op/s 44526376.188op/s 44565901.291op/s 44574913.219op/s 1.40% -0.353 -0.533 0.89% 27680.375op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 1.613µs 1.613µs ± 0.000µs 1.613µs ± 0.000µs 1.614µs 1.614µs 1.615µs 1.615µs 0.13% 0.746 1.233 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 619018427.334op/s 619797245.610op/s ± 172938.847op/s 619828109.205op/s ± 120244.436op/s 619930836.403op/s 620029348.866op/s 620084647.389op/s 620140333.015op/s 0.05% -0.743 1.224 0.03% 12228.623op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 85.921µs 86.633µs ± 0.314µs 86.609µs ± 0.211µs 86.826µs 87.178µs 87.387µs 87.653µs 1.21% 0.347 -0.080 0.36% 0.022µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 11408581.122op/s 11543125.138op/s ± 41770.473op/s 11546153.934op/s ± 28177.410op/s 11572347.380op/s 11605639.183op/s 11629929.066op/s 11638637.950op/s 0.80% -0.327 -0.104 0.36% 2953.618op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 79.327µs 80.122µs ± 0.535µs 80.076µs ± 0.345µs 80.398µs 81.099µs 81.420µs 83.049µs 3.71% 1.269 3.782 0.67% 0.038µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 12041050.542op/s 12481577.349op/s ± 82591.914op/s 12488213.700op/s ± 54021.024op/s 12546056.902op/s 12586820.873op/s 12602288.402op/s 12606006.429op/s 0.94% -1.189 3.318 0.66% 5840.130op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 1.613µs 1.613µs ± 0.000µs 1.613µs ± 0.000µs 1.614µs 1.614µs 1.615µs 1.615µs 0.12% 0.662 0.589 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 619071147.528op/s 619779442.674op/s ± 175121.481op/s 619791946.149op/s ± 133711.114op/s 619917823.626op/s 620007396.568op/s 620054205.969op/s 620101639.832op/s 0.05% -0.660 0.583 0.03% 12382.959op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 77.130µs 78.209µs ± 0.552µs 78.142µs ± 0.357µs 78.543µs 79.302µs 79.912µs 80.118µs 2.53% 0.807 0.653 0.70% 0.039µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 12481646.860op/s 12786870.593op/s ± 89756.483op/s 12797213.409op/s ± 58507.353op/s 12850825.345op/s 12916024.596op/s 12930802.379op/s 12965194.732op/s 1.31% -0.765 0.556 0.70% 6346.742op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 94.272µs 94.589µs ± 0.296µs 94.511µs ± 0.153µs 94.711µs 95.162µs 95.541µs 95.654µs 1.21% 1.405 1.607 0.31% 0.021µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 10454387.115op/s 10572194.007op/s ± 32923.902op/s 10580829.135op/s ± 17182.149op/s 10596904.909op/s 10604686.847op/s 10606078.578op/s 10607649.176op/s 0.25% -1.390 1.549 0.31% 2328.071op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 22.471µs 22.768µs ± 0.138µs 22.747µs ± 0.091µs 22.850µs 22.987µs 23.173µs 23.339µs 2.60% 0.931 2.160 0.60% 0.010µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 42846243.765op/s 43923841.899op/s ± 264357.823op/s 43961130.915op/s ± 176082.331op/s 44080900.301op/s 44302317.705op/s 44440691.151op/s 44501865.480op/s 1.23% -0.872 1.967 0.60% 18692.921op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [1.613µs; 1.614µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number/ throughput [619754516.327op/s; 619805571.475op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [105.351µs; 105.635µs] or [-0.135%; +0.135%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [9467550.953op/s; 9492751.821op/s] or [-0.133%; +0.133%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [97.179µs; 97.302µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/ 378282246310005 throughput [10277578.730op/s; 10290423.098op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/37828224631 execution_time [1.613µs; 1.614µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number/37828224631 throughput [619517102.854op/s; 619847962.359op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number/378282246310005 execution_time [95.249µs; 95.439µs] or [-0.100%; +0.100%] None None None
credit_card/is_card_number/378282246310005 throughput [10478460.590op/s; 10499279.223op/s] or [-0.099%; +0.099%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [94.694µs; 94.816µs] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [10546960.502op/s; 10560555.634op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/x371413321323331 execution_time [22.738µs; 22.795µs] or [-0.124%; +0.124%] None None None
credit_card/is_card_number/x371413321323331 throughput [43873259.145op/s; 43981764.222op/s] or [-0.124%; +0.124%] None None None
credit_card/is_card_number_no_luhn/ execution_time [1.613µs; 1.613µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ throughput [619773277.949op/s; 619821213.271op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [86.589µs; 86.676µs] or [-0.050%; +0.050%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [11537336.152op/s; 11548914.124op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [80.048µs; 80.196µs] or [-0.092%; +0.092%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [12470130.904op/s; 12493023.794op/s] or [-0.092%; +0.092%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [1.613µs; 1.614µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [619755172.521op/s; 619803712.827op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [78.133µs; 78.286µs] or [-0.098%; +0.098%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [12774431.208op/s; 12799309.979op/s] or [-0.097%; +0.097%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [94.548µs; 94.630µs] or [-0.043%; +0.043%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [10567631.071op/s; 10576756.943op/s] or [-0.043%; +0.043%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [22.748µs; 22.787µs] or [-0.084%; +0.084%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [43887204.447op/s; 43960479.351op/s] or [-0.083%; +0.083%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2734124 1724943806 bob/fix-lsan
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.147µs 1.346µs ± 0.061µs 1.352µs ± 0.050µs 1.390µs 1.433µs 1.448µs 1.449µs 7.16% -0.628 0.783 4.49% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.337µs; 1.354µs] or [-0.623%; +0.623%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2734124 1724943806 bob/fix-lsan
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.676µs 2.735µs ± 0.019µs 2.736µs ± 0.008µs 2.744µs 2.766µs 2.769µs 2.780µs 1.60% -0.835 1.784 0.69% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.732µs; 2.737µs] or [-0.096%; +0.096%] None None None

Baseline

Omitted due to size.

@bwoebi bwoebi merged commit 3b99aa7 into main Aug 29, 2024
30 checks passed
@bwoebi bwoebi deleted the bob/fix-lsan branch August 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants