Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dogstatsd aggregator #654

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Fix dogstatsd aggregator #654

merged 6 commits into from
Oct 3, 2024

Conversation

alexgallotta
Copy link
Contributor

@alexgallotta alexgallotta commented Sep 27, 2024 •
edited
Loading

  • allow creation of Metric outside this crate, setting id public and with constructor
  • make it easier to generate metrics

@alexgallotta alexgallotta requested a review from a team as a code owner September 27, 2024 19:59
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.26415% with 20 lines in your changes missing coverage. Please review.

Project coverage is 71.78%. Comparing base (6e7d1e6) to head (fb23ded).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   71.82%   71.78%   -0.04%     
==========================================
  Files         271      271              
  Lines       40869    40895      +26     
==========================================
+ Hits        29354    29357       +3     
- Misses      11515    11538      +23
Components Coverage Δ
crashtracker 20.41% <ø> (ø)
crashtracker-ffi 9.07% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.60% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 82.73% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.05% <62.26%> (-1.86%) ⬇️
dogstatsd-client 79.77% <ø> (ø)
ipc 82.69% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.07% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.66% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.36% <ø> (ø)

@pr-commenter
Copy link

pr-commenter bot commented Oct 1, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-10-03 14:03:22

Comparing candidate commit fb23ded in PR branch fix-dogstatsd-aggregator with baseline commit 6e7d1e6 in branch main.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 48 metrics, 2 unstable metrics.

scenario:normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて

  • 🟩 execution_time [-20.032µs; -19.902µs] or [-4.100%; -4.074%]
  • 🟩 throughput [+86947.920op/s; +87507.467op/s] or [+4.248%; +4.275%]

scenario:tags/replace_trace_tags

  • 🟥 execution_time [+142.520ns; +151.106ns] or [+5.151%; +5.462%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fb23ded 1727963553 fix-dogstatsd-aggregator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.339µs 3.222µs ± 1.597µs 3.051µs ± 0.029µs 3.077µs 3.164µs 13.774µs 18.475µs 505.53% 7.794 62.724 49.44% 0.113µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.001µs; 3.443µs] or [-6.869%; +6.869%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fb23ded 1727963553 fix-dogstatsd-aggregator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 269.978µs 271.641µs ± 0.938µs 271.464µs ± 0.566µs 272.140µs 273.494µs 274.203µs 274.572µs 1.15% 0.871 0.473 0.34% 0.066µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3642031.962op/s 3681371.408op/s ± 12677.063op/s 3683735.132op/s ± 7690.026op/s 3690620.568op/s 3697161.281op/s 3701903.428op/s 3704002.768op/s 0.55% -0.853 0.434 0.34% 896.404op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 26.561µs 26.621µs ± 0.041µs 26.605µs ± 0.023µs 26.647µs 26.693µs 26.738µs 26.748µs 0.53% 0.787 -0.145 0.15% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 37386503.403op/s 37564022.695op/s ± 57335.817op/s 37586213.379op/s ± 32763.165op/s 37610006.011op/s 37628300.757op/s 37648886.837op/s 37649880.514op/s 0.17% -0.781 -0.160 0.15% 4054.255op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.109µs 16.138µs ± 0.027µs 16.121µs ± 0.009µs 16.156µs 16.194µs 16.213µs 16.239µs 0.73% 1.028 0.592 0.17% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 61579707.807op/s 61965246.418op/s ± 102956.369op/s 62030287.185op/s ± 34792.429op/s 62049205.789op/s 62062674.532op/s 62074280.732op/s 62078055.202op/s 0.08% -1.021 0.563 0.17% 7280.115op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [271.511µs; 271.771µs] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3679614.489op/s; 3683128.327op/s] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [26.616µs; 26.627µs] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [37556076.502op/s; 37571968.888op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.134µs; 16.142µs] or [-0.023%; +0.023%] None None None
normalization/normalize_name/normalize_name/good throughput [61950977.655op/s; 61979515.180op/s] or [-0.023%; +0.023%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fb23ded 1727963553 fix-dogstatsd-aggregator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.962µs 38.759µs ± 1.451µs 38.063µs ± 0.073µs 38.270µs 41.939µs 42.007µs 42.010µs 10.37% 1.689 0.893 3.73% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.558µs; 38.960µs] or [-0.519%; +0.519%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fb23ded 1727963553 fix-dogstatsd-aggregator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 506.213µs 507.286µs ± 0.915µs 507.021µs ± 0.283µs 507.437µs 508.799µs 510.035µs 514.429µs 1.46% 3.587 20.496 0.18% 0.065µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1943901.518op/s 1971279.111op/s ± 3533.753op/s 1972305.696op/s ± 1101.553op/s 1973235.670op/s 1974134.736op/s 1975259.659op/s 1975454.857op/s 0.16% -3.536 19.944 0.18% 249.874op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 468.007µs 468.562µs ± 0.269µs 468.582µs ± 0.188µs 468.718µs 469.017µs 469.351µs 469.493µs 0.19% 0.463 0.407 0.06% 0.019µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2129957.209op/s 2134191.144op/s ± 1225.308op/s 2134096.516op/s ± 856.095op/s 2135132.179op/s 2136021.188op/s 2136598.834op/s 2136718.976op/s 0.12% -0.460 0.399 0.06% 86.642op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 180.491µs 180.821µs ± 0.136µs 180.826µs ± 0.095µs 180.919µs 181.065µs 181.106µs 181.172µs 0.19% -0.036 -0.399 0.08% 0.010µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5519627.864op/s 5530340.583op/s ± 4168.717op/s 5530181.166op/s ± 2908.321op/s 5533249.736op/s 5537381.502op/s 5539102.343op/s 5540431.229op/s 0.19% 0.040 -0.399 0.08% 294.773op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.131µs 44.259µs ± 0.058µs 44.254µs ± 0.038µs 44.295µs 44.351µs 44.432µs 44.492µs 0.54% 0.726 1.104 0.13% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22475918.939op/s 22594538.417op/s ± 29597.067op/s 22596955.955op/s ± 19168.156op/s 22615962.259op/s 22636470.706op/s 22644092.479op/s 22659833.433op/s 0.28% -0.716 1.075 0.13% 2092.829op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.188µs 49.398µs ± 0.081µs 49.398µs ± 0.055µs 49.453µs 49.524µs 49.588µs 49.618µs 0.44% -0.054 -0.193 0.16% 0.006µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20154066.118op/s 20243985.740op/s ± 33355.913op/s 20243558.259op/s ± 22590.475op/s 20266500.954op/s 20303010.886op/s 20320401.808op/s 20329955.172op/s 0.43% 0.063 -0.195 0.16% 2358.619op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [507.160µs; 507.413µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1970789.366op/s; 1971768.855op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [468.524µs; 468.599µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2134021.328op/s; 2134360.959op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [180.802µs; 180.840µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5529762.839op/s; 5530918.327op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [44.251µs; 44.267µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22590436.548op/s; 22598640.286op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.386µs; 49.409µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20239362.931op/s; 20248608.549op/s] or [-0.023%; +0.023%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fb23ded 1727963553 fix-dogstatsd-aggregator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.849µs 2.914µs ± 0.024µs 2.922µs ± 0.016µs 2.931µs 2.944µs 2.949µs 2.956µs 1.15% -0.862 0.344 0.83% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.910µs; 2.917µs] or [-0.115%; +0.115%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fb23ded 1727963553 fix-dogstatsd-aggregator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 75.564µs 75.729µs ± 0.120µs 75.711µs ± 0.035µs 75.749µs 75.846µs 76.048µs 76.967µs 1.66% 6.464 58.996 0.16% 0.008µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [75.713µs; 75.746µs] or [-0.022%; +0.022%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fb23ded 1727963553 fix-dogstatsd-aggregator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 290.638ns 303.252ns ± 14.988ns 295.769ns ± 4.439ns 310.600ns 331.327ns 353.763ns 362.711ns 22.63% 1.652 2.558 4.93% 1.060ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [301.175ns; 305.329ns] or [-0.685%; +0.685%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fb23ded 1727963553 fix-dogstatsd-aggregator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.617µs 26.823µs ± 11.509µs 18.432µs ± 0.484µs 35.089µs 42.487µs 46.931µs 97.336µs 428.10% 2.196 9.899 42.80% 0.814µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [25.228µs; 28.418µs] or [-5.947%; +5.947%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fb23ded 1727963553 fix-dogstatsd-aggregator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 2.013µs 2.014µs ± 0.001µs 2.014µs ± 0.000µs 2.015µs 2.016µs 2.017µs 2.024µs 0.48% 4.372 35.169 0.05% 0.000µs 1 200
credit_card/is_card_number/ throughput 494095631.836op/s 496432903.308op/s ± 253164.471op/s 496478105.320op/s ± 122704.645op/s 496599965.573op/s 496662018.601op/s 496683735.736op/s 496713984.384op/s 0.05% -4.344 34.816 0.05% 17901.431op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 123.918µs 125.595µs ± 0.590µs 125.642µs ± 0.379µs 125.937µs 126.562µs 126.747µs 127.067µs 1.13% -0.251 0.006 0.47% 0.042µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 7869852.317op/s 7962292.123op/s ± 37427.393op/s 7959091.860op/s ± 24057.911op/s 7987036.454op/s 8026317.507op/s 8061986.031op/s 8069862.413op/s 1.39% 0.279 0.028 0.47% 2646.516op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 115.477µs 117.107µs ± 0.542µs 117.133µs ± 0.355µs 117.456µs 117.975µs 118.159µs 118.664µs 1.31% -0.274 0.097 0.46% 0.038µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 8427156.492op/s 8539370.656op/s ± 39575.899op/s 8537274.510op/s ± 25978.857op/s 8564658.173op/s 8606346.666op/s 8640808.407op/s 8659698.228op/s 1.43% 0.302 0.116 0.46% 2798.439op/s 1 200
credit_card/is_card_number/37828224631 execution_time 2.013µs 2.014µs ± 0.001µs 2.014µs ± 0.001µs 2.015µs 2.016µs 2.017µs 2.023µs 0.42% 3.652 26.828 0.05% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 494417168.793op/s 496467214.164op/s ± 237299.806op/s 496506578.713op/s ± 131502.124op/s 496629980.482op/s 496700860.864op/s 496748391.582op/s 496800166.661op/s 0.06% -3.629 26.569 0.05% 16779.630op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 111.016µs 113.053µs ± 0.675µs 113.084µs ± 0.476µs 113.515µs 114.158µs 114.352µs 114.470µs 1.23% -0.221 -0.342 0.60% 0.048µs 1 200
credit_card/is_card_number/378282246310005 throughput 8735885.900op/s 8845752.025op/s ± 52918.472op/s 8842991.445op/s ± 37209.197op/s 8887247.911op/s 8928840.137op/s 8973109.437op/s 9007739.774op/s 1.86% 0.250 -0.310 0.60% 3741.901op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 112.707µs 113.565µs ± 0.439µs 113.537µs ± 0.336µs 113.869µs 114.382µs 114.700µs 114.953µs 1.25% 0.582 -0.205 0.39% 0.031µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 8699216.855op/s 8805673.962op/s ± 33987.823op/s 8807671.395op/s ± 26056.654op/s 8834062.339op/s 8849483.652op/s 8862334.194op/s 8872535.952op/s 0.74% -0.565 -0.237 0.39% 2403.302op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 23.263µs 24.021µs ± 0.386µs 24.049µs ± 0.248µs 24.246µs 24.739µs 24.892µs 25.074µs 4.26% 0.188 -0.412 1.60% 0.027µs 1 200
credit_card/is_card_number/x371413321323331 throughput 39881524.005op/s 41641459.242op/s ± 668304.351op/s 41582043.451op/s ± 424307.065op/s 42106980.032op/s 42705926.320op/s 42950493.044op/s 42986975.361op/s 3.38% -0.114 -0.467 1.60% 47256.254op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 2.013µs 2.014µs ± 0.001µs 2.014µs ± 0.001µs 2.015µs 2.016µs 2.017µs 2.018µs 0.18% 1.211 1.711 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 495622351.939op/s 496463685.929op/s ± 193688.770op/s 496519215.294op/s ± 124979.131op/s 496604634.598op/s 496684023.916op/s 496717793.864op/s 496735005.331op/s 0.04% -1.208 1.700 0.04% 13695.864op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 97.539µs 98.441µs ± 0.432µs 98.397µs ± 0.299µs 98.721µs 99.196µs 99.541µs 99.970µs 1.60% 0.556 0.121 0.44% 0.031µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 10002973.433op/s 10158578.685op/s ± 44424.552op/s 10162926.667op/s ± 30919.064op/s 10191570.043op/s 10221441.108op/s 10234014.147op/s 10252333.034op/s 0.88% -0.532 0.073 0.44% 3141.290op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 88.328µs 90.589µs ± 0.661µs 90.615µs ± 0.460µs 91.049µs 91.599µs 92.127µs 92.404µs 1.98% -0.079 -0.021 0.73% 0.047µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 10821988.526op/s 11039494.683op/s ± 80584.197op/s 11035736.151op/s ± 56283.797op/s 11097372.975op/s 11169723.818op/s 11202792.381op/s 11321430.192op/s 2.59% 0.123 0.010 0.73% 5698.163op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 2.013µs 2.014µs ± 0.001µs 2.014µs ± 0.000µs 2.015µs 2.015µs 2.016µs 2.025µs 0.50% 6.615 70.932 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 493944282.886op/s 496437886.894op/s ± 227396.212op/s 496415410.823op/s ± 119889.619op/s 496592254.427op/s 496665081.540op/s 496694073.772op/s 496703052.208op/s 0.06% -6.575 70.356 0.05% 16079.340op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 84.934µs 86.644µs ± 0.541µs 86.674µs ± 0.357µs 87.009µs 87.490µs 87.838µs 87.958µs 1.48% -0.264 0.229 0.62% 0.038µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 11369053.593op/s 11541951.665op/s ± 72136.357op/s 11537462.918op/s ± 47435.123op/s 11589182.948op/s 11653558.693op/s 11730757.793op/s 11773782.203op/s 2.05% 0.304 0.274 0.62% 5100.811op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 112.192µs 113.552µs ± 0.418µs 113.552µs ± 0.340µs 113.862µs 114.206µs 114.561µs 114.833µs 1.13% 0.216 -0.223 0.37% 0.030µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 8708327.108op/s 8806652.469op/s ± 32375.277op/s 8806546.691op/s ± 26470.772op/s 8834917.580op/s 8850463.471op/s 8855368.201op/s 8913261.150op/s 1.21% -0.197 -0.225 0.37% 2289.278op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 23.415µs 24.168µs ± 0.401µs 24.152µs ± 0.284µs 24.458µs 24.850µs 25.020µs 25.123µs 4.02% 0.143 -0.641 1.66% 0.028µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 39803798.474op/s 41388888.238op/s ± 685591.346op/s 41404159.745op/s ± 484825.560op/s 41866256.868op/s 42548070.997op/s 42686686.616op/s 42707180.802op/s 3.15% -0.077 -0.670 1.65% 48478.629op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [2.014µs; 2.015µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/ throughput [496397817.147op/s; 496467989.469op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [125.513µs; 125.676µs] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [7957105.046op/s; 7967479.200op/s] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [117.032µs; 117.182µs] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/ 378282246310005 throughput [8533885.817op/s; 8544855.495op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/37828224631 execution_time [2.014µs; 2.014µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/37828224631 throughput [496434326.693op/s; 496500101.635op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/378282246310005 execution_time [112.959µs; 113.146µs] or [-0.083%; +0.083%] None None None
credit_card/is_card_number/378282246310005 throughput [8838418.033op/s; 8853086.016op/s] or [-0.083%; +0.083%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [113.504µs; 113.626µs] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [8800963.577op/s; 8810384.347op/s] or [-0.053%; +0.053%] None None None
credit_card/is_card_number/x371413321323331 execution_time [23.967µs; 24.074µs] or [-0.223%; +0.223%] None None None
credit_card/is_card_number/x371413321323331 throughput [41548838.686op/s; 41734079.797op/s] or [-0.222%; +0.222%] None None None
credit_card/is_card_number_no_luhn/ execution_time [2.014µs; 2.014µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/ throughput [496436842.529op/s; 496490529.330op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [98.381µs; 98.501µs] or [-0.061%; +0.061%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [10152421.870op/s; 10164735.501op/s] or [-0.061%; +0.061%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [90.497µs; 90.680µs] or [-0.101%; +0.101%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11028326.488op/s; 11050662.877op/s] or [-0.101%; +0.101%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [2.014µs; 2.014µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [496406371.966op/s; 496469401.822op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [86.569µs; 86.719µs] or [-0.086%; +0.086%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [11531954.260op/s; 11551949.071op/s] or [-0.087%; +0.087%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [113.494µs; 113.610µs] or [-0.051%; +0.051%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [8802165.567op/s; 8811139.371op/s] or [-0.051%; +0.051%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [24.112µs; 24.223µs] or [-0.230%; +0.230%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [41293871.871op/s; 41483904.604op/s] or [-0.230%; +0.230%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fb23ded 1727963553 fix-dogstatsd-aggregator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.917ms 8.953ms ± 0.023ms 8.951ms ± 0.009ms 8.960ms 8.980ms 9.021ms 9.152ms 2.25% 4.180 29.817 0.26% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.950ms; 8.956ms] or [-0.036%; +0.036%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fb23ded 1727963553 fix-dogstatsd-aggregator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 137.699µs 138.619µs ± 0.616µs 138.526µs ± 0.159µs 138.695µs 139.316µs 140.193µs 145.370µs 4.94% 6.983 70.903 0.44% 0.044µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [138.534µs; 138.705µs] or [-0.062%; +0.062%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz fb23ded 1727963553 fix-dogstatsd-aggregator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.142µs 1.205µs ± 0.023µs 1.213µs ± 0.012µs 1.223µs 1.227µs 1.228µs 1.229µs 1.28% -1.323 0.869 1.93% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.202µs; 1.208µs] or [-0.268%; +0.268%] None None None

Baseline

Omitted due to size.

bantonsson
bantonsson requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get what the fix is since there is no description about what was wrong, how it's fixed etc.

Adding a test that ensures that whatever happened, doesn't happen again would be good as well.

dogstatsd/src/aggregator.rs Show resolved Hide resolved
@alexgallotta
Copy link
Contributor Author

I don't get what the fix is since there is no description about what was wrong, how it's fixed etc.

Adding a test that ensures that whatever happened, doesn't happen again would be good as well.

Good point, I added it in the description

@alexgallotta alexgallotta merged commit d01cf11 into main Oct 3, 2024
30 checks passed
@alexgallotta alexgallotta deleted the fix-dogstatsd-aggregator branch October 3, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astuyve astuyve astuyve approved these changes

@bantonsson bantonsson bantonsson approved these changes

@duncanista duncanista Awaiting requested review from duncanista

@duncanpharvey duncanpharvey Awaiting requested review from duncanpharvey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexgallotta @codecov-commenter @bantonsson @astuyve