Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] refactor proxy handling. #667

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[WIP] refactor proxy handling. #667

wants to merge 7 commits into from
+58 −80

Conversation

hoolioh
Copy link
Contributor

@hoolioh hoolioh commented Oct 7, 2024

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented Oct 7, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-10-11 15:37:14

Comparing candidate commit 059dd92 in PR branch julio/clean-trace-utils-API with baseline commit 356f76a in branch main.

Found 30 performance improvements and 8 performance regressions! Performance is the same for 13 metrics, 2 unstable metrics.

scenario:benching string interning on wordpress profile

  • 🟩 execution_time [-3.645µs; -3.500µs] or [-2.542%; -2.441%]

scenario:concentrator/add_spans_to_concentrator

  • 🟩 execution_time [-260.246µs; -254.057µs] or [-2.797%; -2.731%]

scenario:credit_card/is_card_number/

  • 🟩 execution_time [-401.116ns; -400.875ns] or [-24.850%; -24.835%]
  • 🟩 throughput [+204703803.797op/s; +204839024.621op/s] or [+33.043%; +33.064%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟩 execution_time [-6.761µs; -6.330µs] or [-6.261%; -5.862%]
  • 🟩 throughput [+578531.968op/s; +618879.823op/s] or [+6.247%; +6.682%]

scenario:credit_card/is_card_number/37828224631

  • 🟩 execution_time [-401.352ns; -400.990ns] or [-24.864%; -24.842%]
  • 🟩 throughput [+204799940.874op/s; +204973892.996op/s] or [+33.058%; +33.086%]

scenario:credit_card/is_card_number/378282246310005

  • 🟩 execution_time [-3.538µs; -3.097µs] or [-3.416%; -2.991%]
  • 🟩 throughput [+299596.865op/s; +343424.242op/s] or [+3.103%; +3.557%]

scenario:credit_card/is_card_number/37828224631000521389798

  • 🟩 execution_time [-14.197µs; -13.976µs] or [-13.122%; -12.918%]
  • 🟩 throughput [+1373044.212op/s; +1393833.058op/s] or [+14.854%; +15.079%]

scenario:credit_card/is_card_number/x371413321323331

  • 🟩 execution_time [-3.139µs; -2.974µs] or [-12.553%; -11.891%]
  • 🟩 throughput [+5417326.529op/s; +5707541.201op/s] or [+13.542%; +14.267%]

scenario:credit_card/is_card_number_no_luhn/

  • 🟩 execution_time [-401.110ns; -400.896ns] or [-24.849%; -24.836%]
  • 🟩 throughput [+204723554.056op/s; +204832843.251op/s] or [+33.046%; +33.063%]

scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005

  • 🟩 execution_time [-4.193µs; -4.039µs] or [-4.635%; -4.465%]
  • 🟩 throughput [+517063.056op/s; +537251.287op/s] or [+4.678%; +4.860%]

scenario:credit_card/is_card_number_no_luhn/ 378282246310005

  • 🟩 execution_time [-3.471µs; -3.257µs] or [-4.084%; -3.831%]
  • 🟩 throughput [+469339.086op/s; +499854.076op/s] or [+3.989%; +4.249%]

scenario:credit_card/is_card_number_no_luhn/37828224631

  • 🟩 execution_time [-401.362ns; -401.058ns] or [-24.863%; -24.845%]
  • 🟩 throughput [+204798251.876op/s; +204975317.381op/s] or [+33.060%; +33.089%]

scenario:credit_card/is_card_number_no_luhn/37828224631000521389798

  • 🟩 execution_time [-14.079µs; -13.883µs] or [-13.022%; -12.840%]
  • 🟩 throughput [+1364193.332op/s; +1382711.573op/s] or [+14.749%; +14.950%]

scenario:credit_card/is_card_number_no_luhn/x371413321323331

  • 🟩 execution_time [-3.118µs; -2.940µs] or [-12.529%; -11.811%]
  • 🟩 throughput [+5399797.421op/s; +5709040.622op/s] or [+13.432%; +14.202%]

scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...

  • 🟥 execution_time [+78.244µs; +78.541µs] or [+40.556%; +40.710%]
  • 🟥 throughput [-1500885.545op/s; -1494406.419op/s] or [-28.956%; -28.831%]

scenario:normalization/normalize_name/normalize_name/bad-name

  • 🟥 execution_time [+8.383µs; +8.397µs] or [+45.950%; +46.024%]
  • 🟥 throughput [-17279508.812op/s; -17253054.302op/s] or [-31.525%; -31.477%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟥 execution_time [+4.752µs; +4.767µs] or [+41.797%; +41.929%]
  • 🟥 throughput [-26005504.798op/s; -25912188.134op/s] or [-29.563%; -29.457%]

scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...

  • 🟩 execution_time [-117.050µs; -116.875µs] or [-18.753%; -18.724%]
  • 🟩 throughput [+369143.203op/s; +369734.655op/s] or [+23.041%; +23.078%]

scenario:normalization/normalize_service/normalize_service/[empty string]

  • 🟩 execution_time [-2.330µs; -2.302µs] or [-4.982%; -4.921%]
  • 🟩 throughput [+1107108.729op/s; +1120421.253op/s] or [+5.178%; +5.241%]

scenario:normalization/normalize_trace/test_trace

  • 🟥 execution_time [+31.538ns; +37.700ns] or [+11.730%; +14.022%]

scenario:sql/obfuscate_sql_string

  • 🟥 execution_time [+3.376µs; +3.445µs] or [+4.966%; +5.067%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 059dd92 1728660367 julio/clean-trace-utils-API
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.136µs 1.191µs ± 0.023µs 1.191µs ± 0.017µs 1.212µs 1.216µs 1.216µs 1.217µs 2.16% -0.808 -0.172 1.91% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.187µs; 1.194µs] or [-0.266%; +0.266%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 059dd92 1728660367 julio/clean-trace-utils-API
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 290.179ns 303.485ns ± 15.809ns 295.098ns ± 3.592ns 309.322ns 340.717ns 343.569ns 345.520ns 17.09% 1.327 0.462 5.20% 1.118ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [301.294ns; 305.676ns] or [-0.722%; +0.722%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 059dd92 1728660367 julio/clean-trace-utils-API
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.378µs 3.185µs ± 1.576µs 3.029µs ± 0.018µs 3.046µs 3.113µs 13.918µs 18.276µs 503.39% 8.030 65.391 49.36% 0.111µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.967µs; 3.404µs] or [-6.858%; +6.858%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 059dd92 1728660367 julio/clean-trace-utils-API
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.010ms 9.047ms ± 0.014ms 9.048ms ± 0.009ms 9.056ms 9.070ms 9.074ms 9.096ms 0.53% 0.059 0.136 0.16% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.045ms; 9.049ms] or [-0.022%; +0.022%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 059dd92 1728660367 julio/clean-trace-utils-API
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 506.167µs 507.218µs ± 0.475µs 507.151µs ± 0.300µs 507.513µs 508.109µs 508.345µs 508.820µs 0.33% 0.475 0.195 0.09% 0.034µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1965330.415op/s 1971542.447op/s ± 1845.387op/s 1971798.640op/s ± 1167.554op/s 1972872.996op/s 1974176.127op/s 1975434.590op/s 1975633.467op/s 0.19% -0.470 0.187 0.09% 130.489op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 468.208µs 468.746µs ± 0.222µs 468.726µs ± 0.146µs 468.891µs 469.097µs 469.314µs 469.606µs 0.19% 0.507 0.814 0.05% 0.016µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2129443.013op/s 2133351.364op/s ± 1011.480op/s 2133441.488op/s ± 665.041op/s 2134029.341op/s 2134950.226op/s 2135546.710op/s 2135805.052op/s 0.11% -0.503 0.806 0.05% 71.522op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 180.297µs 180.774µs ± 0.213µs 180.784µs ± 0.142µs 180.918µs 181.136µs 181.226µs 181.270µs 0.27% -0.076 -0.434 0.12% 0.015µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5516643.039op/s 5531764.910op/s ± 6518.127op/s 5531477.887op/s ± 4349.003op/s 5536024.005op/s 5542986.084op/s 5546136.863op/s 5546411.492op/s 0.27% 0.081 -0.434 0.12% 460.901op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.352µs 44.458µs ± 0.050µs 44.454µs ± 0.024µs 44.478µs 44.522µs 44.709µs 44.767µs 0.70% 2.486 12.812 0.11% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22338106.138op/s 22493284.744op/s ± 25135.004op/s 22495232.545op/s ± 12323.879op/s 22507602.712op/s 22524111.116op/s 22538713.932op/s 22547061.077op/s 0.23% -2.457 12.617 0.11% 1777.313op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.031µs 49.159µs ± 0.055µs 49.158µs ± 0.027µs 49.185µs 49.250µs 49.319µs 49.344µs 0.38% 0.489 0.808 0.11% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20265878.793op/s 20342146.996op/s ± 22669.244op/s 20342602.939op/s ± 11161.053op/s 20354691.272op/s 20376224.458op/s 20390887.320op/s 20395147.586op/s 0.26% -0.480 0.794 0.11% 1602.958op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [507.152µs; 507.283µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1971286.694op/s; 1971798.200op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [468.715µs; 468.777µs] or [-0.007%; +0.007%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2133211.182op/s; 2133491.545op/s] or [-0.007%; +0.007%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [180.745µs; 180.804µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5530861.560op/s; 5532668.260op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [44.451µs; 44.465µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22489801.274op/s; 22496768.214op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.151µs; 49.167µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20339005.257op/s; 20345288.735op/s] or [-0.015%; +0.015%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 059dd92 1728660367 julio/clean-trace-utils-API
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.707µs 2.760µs ± 0.020µs 2.758µs ± 0.005µs 2.764µs 2.803µs 2.810µs 2.818µs 2.16% 0.306 1.621 0.72% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.758µs; 2.763µs] or [-0.100%; +0.100%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 059dd92 1728660367 julio/clean-trace-utils-API
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 1.212µs 1.213µs ± 0.001µs 1.213µs ± 0.000µs 1.213µs 1.214µs 1.214µs 1.220µs 0.58% 6.701 71.120 0.05% 0.000µs 1 200
credit_card/is_card_number/ throughput 819538008.809op/s 824286321.528op/s ± 433035.989op/s 824263089.903op/s ± 209504.920op/s 824557511.101op/s 824671700.462op/s 824716357.072op/s 825126854.246op/s 0.10% -6.657 70.474 0.05% 30620.268op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 105.853µs 109.784µs ± 1.232µs 109.676µs ± 0.745µs 110.490µs 111.956µs 112.938µs 113.309µs 3.31% 0.237 0.505 1.12% 0.087µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8825461.087op/s 9109954.765op/s ± 102024.077op/s 9117777.424op/s ± 62376.804op/s 9177349.499op/s 9258644.421op/s 9344621.512op/s 9447060.438op/s 3.61% -0.155 0.511 1.12% 7214.192op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 99.060µs 101.436µs ± 1.317µs 101.413µs ± 1.039µs 102.411µs 103.477µs 104.674µs 104.892µs 3.43% 0.284 -0.653 1.29% 0.093µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 9533634.808op/s 9860076.620op/s ± 127543.891op/s 9860659.971op/s ± 100066.899op/s 9972800.457op/s 10051438.593op/s 10063419.117op/s 10094853.898op/s 2.38% -0.235 -0.714 1.29% 9018.715op/s 1 200
credit_card/is_card_number/37828224631 execution_time 1.212µs 1.213µs ± 0.001µs 1.213µs ± 0.000µs 1.213µs 1.214µs 1.214µs 1.221µs 0.62% 6.503 69.872 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 819335808.205op/s 824397175.342op/s ± 463715.560op/s 824438052.153op/s ± 204123.874op/s 824607186.792op/s 824947555.053op/s 825097171.760op/s 825145196.224op/s 0.09% -6.453 69.169 0.06% 32789.642op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 95.837µs 100.246µs ± 1.494µs 100.478µs ± 1.115µs 101.374µs 102.218µs 102.920µs 103.458µs 2.97% -0.488 -0.332 1.49% 0.106µs 1 200
credit_card/is_card_number/378282246310005 throughput 9665753.414op/s 9977638.100op/s ± 149852.975op/s 9952454.953op/s ± 110914.963op/s 10085587.111op/s 10238509.824op/s 10323642.351op/s 10434433.463op/s 4.84% 0.553 -0.236 1.50% 10596.206op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 92.849µs 94.104µs ± 0.418µs 94.090µs ± 0.236µs 94.338µs 94.842µs 95.062µs 95.182µs 1.16% -0.058 0.299 0.44% 0.030µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 10506140.692op/s 10626769.027op/s ± 47251.200op/s 10628070.297op/s ± 26685.879op/s 10653209.507op/s 10706688.003op/s 10743698.947op/s 10770145.961op/s 1.34% 0.089 0.316 0.44% 3341.164op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 21.374µs 21.951µs ± 0.332µs 21.900µs ± 0.201µs 22.110µs 22.567µs 22.818µs 23.287µs 6.33% 0.893 0.885 1.51% 0.023µs 1 200
credit_card/is_card_number/x371413321323331 throughput 42942422.364op/s 45566826.760op/s ± 680833.440op/s 45662250.918op/s ± 421508.509op/s 46076376.773op/s 46495485.610op/s 46713433.961op/s 46786824.458op/s 2.46% -0.802 0.623 1.49% 48142.194op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 1.213µs 1.213µs ± 0.000µs 1.213µs ± 0.000µs 1.213µs 1.214µs 1.215µs 1.215µs 0.13% 0.904 0.255 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 823284807.504op/s 824295356.538op/s ± 314885.452op/s 824317970.133op/s ± 227475.588op/s 824554890.531op/s 824648533.581op/s 824697098.254op/s 824722505.339op/s 0.05% -0.902 0.250 0.04% 22265.764op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 84.931µs 86.353µs ± 0.495µs 86.245µs ± 0.218µs 86.527µs 87.427µs 87.835µs 88.117µs 2.17% 0.975 2.026 0.57% 0.035µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 11348484.669op/s 11580788.537op/s ± 66053.164op/s 11594868.692op/s ± 29410.361op/s 11617701.605op/s 11661805.399op/s 11721663.170op/s 11774321.180op/s 1.55% -0.923 1.954 0.57% 4670.664op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 79.828µs 81.642µs ± 0.489µs 81.652µs ± 0.285µs 81.907µs 82.437µs 82.741µs 83.213µs 1.91% -0.103 0.894 0.60% 0.035µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 12017361.277op/s 12249037.330op/s ± 73420.837op/s 12247100.488op/s ± 42752.126op/s 12293475.578op/s 12376959.128op/s 12438167.542op/s 12526885.701op/s 2.28% 0.155 0.938 0.60% 5191.637op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 1.212µs 1.213µs ± 0.001µs 1.213µs ± 0.000µs 1.213µs 1.214µs 1.215µs 1.223µs 0.80% 6.784 71.327 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 817970625.100op/s 824362208.420op/s ± 583576.674op/s 824474252.635op/s ± 250940.499op/s 824609723.413op/s 825001259.322op/s 825084354.891op/s 825131897.980op/s 0.08% -6.726 70.480 0.07% 41265.102op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 77.755µs 79.031µs ± 0.426µs 79.055µs ± 0.296µs 79.317µs 79.722µs 79.922µs 80.222µs 1.48% -0.022 -0.094 0.54% 0.030µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 12465472.115op/s 12653617.331op/s ± 68276.501op/s 12649401.135op/s ± 47472.260op/s 12700912.247op/s 12769261.624op/s 12788896.906op/s 12860898.847op/s 1.67% 0.053 -0.095 0.54% 4827.878op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 92.826µs 94.140µs ± 0.374µs 94.166µs ± 0.213µs 94.360µs 94.771µs 94.972µs 95.199µs 1.10% -0.160 0.531 0.40% 0.026µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 10504359.456op/s 10622599.187op/s ± 42260.936op/s 10619565.315op/s ± 23996.081op/s 10644704.288op/s 10702019.740op/s 10714264.805op/s 10772791.754op/s 1.44% 0.190 0.553 0.40% 2988.299op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 21.298µs 21.860µs ± 0.299µs 21.818µs ± 0.163µs 21.987µs 22.498µs 22.656µs 22.813µs 4.56% 0.920 0.772 1.37% 0.021µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 43834329.073op/s 45753956.351op/s ± 619246.898op/s 45833669.036op/s ± 341221.856op/s 46165990.890op/s 46571488.837op/s 46831664.672op/s 46951977.145op/s 2.44% -0.842 0.624 1.35% 43787.368op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [1.213µs; 1.213µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/ throughput [824226306.905op/s; 824346336.152op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [109.613µs; 109.955µs] or [-0.156%; +0.156%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [9095815.210op/s; 9124094.321op/s] or [-0.155%; +0.155%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [101.254µs; 101.618µs] or [-0.180%; +0.180%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9842400.263op/s; 9877752.976op/s] or [-0.179%; +0.179%] None None None
credit_card/is_card_number/37828224631 execution_time [1.213µs; 1.213µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631 throughput [824332908.825op/s; 824461441.859op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/378282246310005 execution_time [100.039µs; 100.453µs] or [-0.207%; +0.207%] None None None
credit_card/is_card_number/378282246310005 throughput [9956869.919op/s; 9998406.281op/s] or [-0.208%; +0.208%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [94.046µs; 94.162µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [10620220.465op/s; 10633317.589op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/x371413321323331 execution_time [21.905µs; 21.997µs] or [-0.210%; +0.210%] None None None
credit_card/is_card_number/x371413321323331 throughput [45472469.793op/s; 45661183.727op/s] or [-0.207%; +0.207%] None None None
credit_card/is_card_number_no_luhn/ execution_time [1.213µs; 1.213µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/ throughput [824251716.442op/s; 824338996.633op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [86.284µs; 86.421µs] or [-0.079%; +0.079%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [11571634.204op/s; 11589942.870op/s] or [-0.079%; +0.079%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [81.574µs; 81.710µs] or [-0.083%; +0.083%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [12238861.908op/s; 12259212.752op/s] or [-0.083%; +0.083%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [1.213µs; 1.213µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [824281330.306op/s; 824443086.534op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [78.972µs; 79.090µs] or [-0.075%; +0.075%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [12644154.865op/s; 12663079.798op/s] or [-0.075%; +0.075%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [94.089µs; 94.192µs] or [-0.055%; +0.055%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [10616742.228op/s; 10628456.147op/s] or [-0.055%; +0.055%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [21.819µs; 21.902µs] or [-0.190%; +0.190%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [45668134.686op/s; 45839778.015op/s] or [-0.188%; +0.188%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 059dd92 1728660367 julio/clean-trace-utils-API
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.024µs 22.779µs ± 9.916µs 18.210µs ± 0.075µs 18.578µs 36.387µs 40.277µs 95.647µs 425.25% 3.698 20.680 43.42% 0.701µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [21.405µs; 24.153µs] or [-6.033%; +6.033%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 059dd92 1728660367 julio/clean-trace-utils-API
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 270.092µs 271.322µs ± 0.726µs 271.166µs ± 0.374µs 271.629µs 272.627µs 273.453µs 274.008µs 1.05% 1.051 1.207 0.27% 0.051µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3649529.369op/s 3685683.514op/s ± 9836.367op/s 3687778.646op/s ± 5078.878op/s 3692438.348op/s 3698266.455op/s 3701784.859op/s 3702447.614op/s 0.40% -1.034 1.159 0.27% 695.536op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 26.559µs 26.634µs ± 0.042µs 26.632µs ± 0.029µs 26.664µs 26.699µs 26.749µs 26.774µs 0.53% 0.368 0.072 0.16% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 37350029.258op/s 37545824.635op/s ± 58854.406op/s 37548382.656op/s ± 40389.994op/s 37582865.001op/s 37636286.507op/s 37651575.044op/s 37652059.411op/s 0.28% -0.359 0.056 0.16% 4161.635op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.099µs 16.127µs ± 0.036µs 16.107µs ± 0.004µs 16.146µs 16.189µs 16.222µs 16.351µs 1.52% 2.235 8.002 0.22% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 61158029.822op/s 62007334.189op/s ± 136264.491op/s 62084712.281op/s ± 15931.821op/s 62094780.242op/s 62105375.834op/s 62111656.493op/s 62116488.437op/s 0.05% -2.203 7.723 0.22% 9635.355op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [271.221µs; 271.423µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3684320.288op/s; 3687046.740op/s] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [26.628µs; 26.640µs] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [37537667.981op/s; 37553981.290op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.122µs; 16.132µs] or [-0.031%; +0.031%] None None None
normalization/normalize_name/normalize_name/good throughput [61988449.241op/s; 62026219.137op/s] or [-0.030%; +0.030%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 059dd92 1728660367 julio/clean-trace-utils-API
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 71.194µs 71.393µs ± 0.225µs 71.358µs ± 0.041µs 71.405µs 71.524µs 71.914µs 74.195µs 3.97% 9.995 118.406 0.32% 0.016µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [71.361µs; 71.424µs] or [-0.044%; +0.044%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 059dd92 1728660367 julio/clean-trace-utils-API
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.749µs 38.190µs ± 0.737µs 37.861µs ± 0.048µs 37.926µs 39.738µs 39.803µs 41.155µs 8.70% 1.793 1.605 1.93% 0.052µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.088µs; 38.292µs] or [-0.267%; +0.267%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 059dd92 1728660367 julio/clean-trace-utils-API
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 138.948µs 139.799µs ± 0.365µs 139.740µs ± 0.175µs 139.940µs 140.405µs 141.041µs 141.619µs 1.34% 1.518 4.768 0.26% 0.026µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [139.748µs; 139.849µs] or [-0.036%; +0.036%] None None None

Baseline

Omitted due to size.

@hoolioh hoolioh force-pushed the julio/clean-trace-utils-API branch from 8cb9142 to 79129f3 Compare October 8, 2024 14:57
@hoolioh hoolioh force-pushed the julio/clean-trace-utils-API branch from 79129f3 to 22bf687 Compare October 8, 2024 15:03
@hoolioh hoolioh force-pushed the julio/clean-trace-utils-API branch from 22bf687 to 9639a8a Compare October 8, 2024 17:15
@hoolioh hoolioh force-pushed the julio/clean-trace-utils-API branch 4 times, most recently from 60fdee9 to e83d8c2 Compare October 9, 2024 20:27
@hoolioh hoolioh force-pushed the julio/clean-trace-utils-API branch 3 times, most recently from 80cfaa9 to 939d63f Compare October 10, 2024 20:00
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.52747% with 150 lines in your changes missing coverage. Please review.

Project coverage is 71.80%. Comparing base (6e8dbae) to head (059dd92).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
- Coverage   71.90%   71.80%   -0.11%     
==========================================
  Files         271      271              
  Lines       40647    40912     +265     
==========================================
+ Hits        29228    29376     +148     
- Misses      11419    11536     +117
Components Coverage Δ
crashtracker 20.41% <ø> (+0.05%) ⬆️
crashtracker-ffi 9.07% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.85% <82.99%> (-0.87%) ⬇️
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 82.73% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.05% <62.26%> (-1.86%) ⬇️
dogstatsd-client 79.77% <ø> (ø)
ipc 82.65% <100.00%> (-0.04%) ⬇️
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.08% <2.12%> (-0.28%) ⬇️
sidecar-ffi 0.00% <0.00%> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.39% <16.66%> (-0.28%) ⬇️
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.25% <86.66%> (-0.12%) ⬇️

@hoolioh hoolioh force-pushed the julio/clean-trace-utils-API branch 2 times, most recently from fe580c0 to 0bd8c8c Compare October 10, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci-build data-pipeline mini-agent sidecar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoolioh @codecov-commenter