Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to obtain required rule data IDs #104

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Sep 16, 2022

Add a function to obtain the require rule data IDs. This provides the WAF user with the ability to filter and discard unnecessary rule IDs before passing them to the WAF.

@codecov-commenter
Copy link

Codecov Report

Merging #104 (e2c465d) into master (ae19584) will increase coverage by 0.16%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   65.13%   65.30%   +0.16%     
==========================================
  Files          50       50              
  Lines        2498     2516      +18     
  Branches     1085     1090       +5     
==========================================
+ Hits         1627     1643      +16     
+ Misses        297      293       -4     
- Partials      574      580       +6     
Flag Coverage Δ
waf_test 65.30% <63.15%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rule_data_dispatcher.hpp 66.03% <57.14%> (+0.08%) ⬆️
src/interface.cpp 52.89% <60.00%> (+4.24%) ⬆️
src/waf.hpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Anilm3 Anilm3 merged commit ab0b2f8 into master Sep 20, 2022
@Anilm3 Anilm3 deleted the anilm3/required-rule-data-ids branch September 20, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants