Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for glob component and arrays on object filter #124

Merged
merged 6 commits into from
Dec 16, 2022

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Dec 14, 2022

This PR introduces support for the glob key path component (*) within object filters. This has been implemented by allowing the trie traverser to keep track and descend through many nodes at the same time. In addition, the use of the glob also allows for arrays within the key path.

@Anilm3 Anilm3 changed the title Multitraverser Support for glob component and arrays on object filter Dec 16, 2022
@Anilm3 Anilm3 marked this pull request as ready for review December 16, 2022 13:17
src/exclusion/object_filter.cpp Outdated Show resolved Hide resolved
src/exclusion/object_filter.cpp Outdated Show resolved Hide resolved
src/exclusion/object_filter.hpp Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #124 (4d1a825) into master (c55f93e) will decrease coverage by 0.16%.
The diff coverage is 50.90%.

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   65.23%   65.06%   -0.17%     
==========================================
  Files          61       61              
  Lines        2908     2943      +35     
  Branches     1272     1298      +26     
==========================================
+ Hits         1897     1915      +18     
- Misses        332      334       +2     
- Partials      679      694      +15     
Flag Coverage Δ
waf_test 65.06% <50.90%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object.cpp 63.02% <0.00%> (ø)
src/utils.h 83.33% <ø> (ø)
src/exclusion/object_filter.cpp 57.40% <25.00%> (+0.80%) ⬆️
src/exclusion/object_filter.hpp 64.21% <57.77%> (-7.93%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Anilm3 Anilm3 merged commit c260ace into master Dec 16, 2022
@Anilm3 Anilm3 deleted the anilm3/input-filter-glob-key-path-component branch December 16, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants