Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raw pointers instead of shared pointers for rule targets #141

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Feb 17, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #141 (1e53fac) into master (15b2282) will not change coverage.
The diff coverage is 61.53%.

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   64.71%   64.71%           
=======================================
  Files          63       63           
  Lines        3143     3143           
  Branches     1447     1447           
=======================================
  Hits         2034     2034           
  Misses        309      309           
  Partials      800      800           
Flag Coverage Δ
waf_test 64.71% <61.53%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/collection.cpp 62.71% <0.00%> (ø)
src/collection.hpp 100.00% <ø> (ø)
src/context.hpp 50.00% <ø> (ø)
src/exclusion/input_filter.hpp 100.00% <ø> (ø)
src/exclusion/rule_filter.hpp 100.00% <ø> (ø)
src/ruleset.hpp 69.23% <ø> (ø)
src/ruleset_builder.cpp 56.71% <40.00%> (ø)
src/context.cpp 61.53% <100.00%> (ø)
src/exclusion/input_filter.cpp 80.76% <100.00%> (ø)
src/exclusion/rule_filter.cpp 80.76% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Anilm3 Anilm3 marked this pull request as ready for review February 17, 2023 16:11
Copy link
Contributor

@cataphract cataphract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just wonder if some/all of the rule * can be made const rule *.

@Anilm3 Anilm3 merged commit c556f39 into master Feb 21, 2023
@Anilm3 Anilm3 deleted the anilm3/use-raw-rule-pointers-for-targets branch February 21, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants