Float and null type support #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cataphract
reviewed
Aug 4, 2023
…value iterator and parameter tests
This was referenced Aug 4, 2023
Closed
estringana
reviewed
Aug 4, 2023
| @@ -95,7 +106,7 @@ ddwaf_object *ddwaf_object_stringl_nc(ddwaf_object *object, const char *string, | |||
| return object; | |||
| } | |||
|
|
|||
| ddwaf_object *ddwaf_object_signed(ddwaf_object *object, int64_t value) | |||
| ddwaf_object *ddwaf_object_string_from_signed(ddwaf_object *object, int64_t value) | |||
There was a problem hiding this comment.
NP: I like this new naming from but it feels a bit inconsistent
estringana
reviewed
Aug 4, 2023
| double ddwaf_object_get_float(const ddwaf_object *object) | ||
| { | ||
| if (object == nullptr || object->type != DDWAF_OBJ_FLOAT) { | ||
| return 0; |
There was a problem hiding this comment.
How do user of this function know if the 0 comes from the object or from this conditional?
There was a problem hiding this comment.
They can't know, although they can always check if their object is null or of an incorrect type, but it's mostly a precaution for incorrect use of the API.
estringana
reviewed
Aug 4, 2023
cataphract
requested changes
Aug 7, 2023
cataphract
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
floatandnulltypes, while also allowinginvalidwithin containers.Breaking changes:
ddwaf_objectnow has one more field in the union for doubles calledf64ddwaf_object_*_forceare now the standard, so the_forcesuffix has been removed.ddwaf_object_signedandddwaf_object_unsignedhave now been renamed toddwaf_object_string_from_*DDWAF_OBJ_FLOATandDDWAF_OBJ_NULL