-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix benchmark variances #246
Conversation
Anilm3
commented
Jan 17, 2024
•
edited
Loading
edited
- Fix some issues on valid test generation.
- Removed "mixed" tests.
- Added fixed-size tests with the nomenclature: `random.x.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
=======================================
Coverage 83.28% 83.28%
=======================================
Files 106 106
Lines 4177 4177
Branches 1915 1915
=======================================
Hits 3479 3479
Misses 279 279
Partials 419 419
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-01-17 17:54:26 Comparing candidate commit f03f900 in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in baseline:
Found 13 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 4 unstable metrics. scenario:bool_equals_matcher.valid
scenario:exact_match_matcher.valid
scenario:float_equals_matcher.valid
scenario:ip_match_matcher.valid
scenario:is_xss_matcher.valid
scenario:lowercase_transformer.valid
scenario:phrase_match_matcher.valid
scenario:regex_match_matcher.case_insensitive_option.valid
scenario:regex_match_matcher.lowercase_transformer.valid
scenario:regex_match_matcher.valid
scenario:ruleset_1.10.0.valid
scenario:signed_equals_matcher.valid
scenario:unsigned_equals_matcher.valid
|
The variability of benchmarks is due to the fact that tests in master are essentially more complex and buggy than the ones in this PR. |