Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECRES-1673 - Remove a few fingerprints causing false positives #252

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

Taiki-San
Copy link
Collaborator

No description provided.

@Taiki-San Taiki-San requested a review from a team as a code owner February 6, 2024 11:02
@pr-commenter
Copy link

pr-commenter bot commented Feb 6, 2024

Benchmarks

Benchmark execution time: 2024-02-06 15:21:16

Comparing candidate commit 9fa6c5d in PR branch emilehugo.spir/libinjection-fp2 with baseline commit 58b8756 in branch master.

Found 1 performance improvements and 8 performance regressions! Performance is the same for 26 metrics, 0 unstable metrics.

scenario:bool_equals_matcher.eval.valid

  • 🟥 execution_time [+43.701ns; +48.861ns] or [+2.992%; +3.346%]

scenario:exact_match_matcher.eval.valid

  • 🟥 execution_time [+38.631ns; +65.325ns] or [+2.039%; +3.447%]

scenario:float_equals_matcher.eval.valid

  • 🟥 execution_time [+32.687ns; +36.419ns] or [+1.853%; +2.064%]

scenario:phrase_match_matcher.eval.valid

  • 🟥 execution_time [+45.046ns; +68.446ns] or [+2.362%; +3.589%]

scenario:regex_match_matcher.case_insensitive_option.eval.valid

  • 🟥 execution_time [+30.132ns; +34.406ns] or [+1.534%; +1.752%]

scenario:signed_equals_matcher.eval.valid

  • 🟥 execution_time [+34.608ns; +37.966ns] or [+2.217%; +2.432%]

scenario:signed_equals_matcher.random

  • 🟩 execution_time [-202.241ns; -168.607ns] or [-2.846%; -2.373%]

scenario:string_equals_matcher.random

  • 🟥 execution_time [+284.156ns; +331.070ns] or [+2.467%; +2.874%]

scenario:unsigned_equals_matcher.eval.valid

  • 🟥 execution_time [+34.001ns; +57.833ns] or [+2.121%; +3.608%]

Copy link
Collaborator

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Taiki-San Taiki-San merged commit 90abe3a into master Feb 6, 2024
25 checks passed
@Taiki-San Taiki-San deleted the emilehugo.spir/libinjection-fp2 branch February 6, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants