Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default obfuscator regex #317

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Jul 4, 2024

This PR updates the default obfuscator regex, used if the user-provided regexes are unusable. A test has also been added to ensure some expected patterns are detected.

Related Jiras: APPSEC-53957

@Anilm3 Anilm3 requested a review from a team as a code owner July 4, 2024 13:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.61%. Comparing base (445c1a8) to head (188354c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   83.61%   83.61%           
=======================================
  Files         137      137           
  Lines        6054     6054           
  Branches     2859     2859           
=======================================
  Hits         5062     5062           
  Misses        369      369           
  Partials      623      623           
Flag Coverage Δ
waf_test 83.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jul 4, 2024

Benchmarks

Benchmark execution time: 2024-07-04 14:04:40

Comparing candidate commit 5e1470e in PR branch anilm3/update-default-key-regex with baseline commit 445c1a8 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 0 unstable metrics.

scenario:lowercase_transformer.random

  • 🟩 execution_time [-88.803µs; -83.844µs] or [-4.418%; -4.171%]

scenario:schema_extraction_processor.random

  • 🟩 execution_time [-107.698µs; -99.891µs] or [-3.398%; -3.151%]

@Anilm3 Anilm3 merged commit 7e6e5b4 into master Jul 5, 2024
44 checks passed
@Anilm3 Anilm3 deleted the anilm3/update-default-key-regex branch July 5, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants