Fix many, but not all, clang-tidy complaints

[Anilm3]

Fix as many clang-tidy warnings as possible and exclude false positives or warnings which can't currently be fixed without significant effort.

The lint job has now been fully enabled, so future PRs will be required to be compliant.

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-08-21 14:33:06

Comparing candidate commit 2393ae3 in PR branch anilm3/fix-lint with baseline commit 7f58573 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 69.15888% with 33 lines in your changes missing coverage. Please review.

Project coverage is 84.57%. Comparing base (7f58573) to head (2393ae3).

Files	Patch %	Lines
src/object.cpp	60.37%	11 Missing and 10 partials ⚠️
src/transformer/common/utf8.cpp	77.77%	3 Missing and 1 partial ⚠️
src/condition/lfi_detector.cpp	40.00%	0 Missing and 3 partials ⚠️
src/parser/rule_override_parser.cpp	0.00%	2 Missing ⚠️
src/condition/shi_detector.cpp	0.00%	0 Missing and 1 partial ⚠️
src/condition/sqli_detector.cpp	66.66%	0 Missing and 1 partial ⚠️
src/condition/ssrf_detector.cpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   84.63%   84.57%   -0.07%     
==========================================
  Files         147      147              
  Lines        7004     7001       -3     
  Branches     3207     3235      +28     
==========================================
- Hits         5928     5921       -7     
- Misses        402      405       +3     
- Partials      674      675       +1     

Flag	Coverage Δ
waf_test	84.57% <69.15%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.