Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Remove extra condition for ruby for GraphQL blocking test #2988

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

y9v
Copy link
Member

@y9v y9v commented Sep 5, 2024

Motivation

I am working on a bugfix for Ruby GraphQL instrumentation and changed our implementation to use resolver names as a key for arguments instead of the query name (since one query might have multiple resolvers).

The PR that is linked above has to be merged for this test to pass.

Changes

This PR removes an extra check for Ruby for the test that asserts that GraphQL arguments were extracted correctly.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@y9v y9v self-assigned this Sep 5, 2024
@y9v y9v requested review from a team as code owners September 5, 2024 15:20
@y9v y9v force-pushed the appsec-fix-graphql-test-for-ruby branch from 7b56b6d to 2ac85a9 Compare September 5, 2024 15:25
@cbeauchesne cbeauchesne marked this pull request as draft September 5, 2024 15:40
@y9v y9v force-pushed the appsec-fix-graphql-test-for-ruby branch from 2ac85a9 to dd14c3c Compare September 10, 2024 11:55
@y9v y9v force-pushed the appsec-fix-graphql-test-for-ruby branch from b27c4b1 to 77b4895 Compare September 12, 2024 09:21
@y9v y9v force-pushed the appsec-fix-graphql-test-for-ruby branch from 77b4895 to e6c59bd Compare September 12, 2024 09:32
@y9v y9v marked this pull request as ready for review September 12, 2024 10:04
@y9v y9v requested review from a team as code owners September 12, 2024 10:04
@y9v y9v merged commit c9f8191 into main Sep 12, 2024
68 checks passed
@y9v y9v deleted the appsec-fix-graphql-test-for-ruby branch September 12, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants