fix: Fix conflicting node id on "local" chain to match node id in chain_spec file #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushmishra2005
approved these changes
Jun 8, 2021
cgroeschel
reviewed
Jun 8, 2021
| @@ -1,7 +1,7 @@ | |||
| # dev, local, brickable, harbour, mainnet | |||
| CHAIN_VERSION=dev | |||
|
|
|||
| BOOTNODE_ID_LOCAL=QmWYmZrHFPkgX8PgMgUpHJsK6Q6vWbeVXrKhciunJdRvKZ | |||
| BOOTNODE_ID_LOCAL=12D3KooWKS7jU8ti7S5PDqCNWEj692eUSK3DLssHNwTQsto9ynVo | |||
There was a problem hiding this comment.
is that node id just a different format and it would also work for dev chain?
There was a problem hiding this comment.
yeh i think it will work for 'dev' too, i will try now.
it's the same as in https://github.com/DataHighway-DHX/node/blob/master/node/src/chain_spec.rs#L258 so there's no conflict. 'dev' doesn't have one in the chain_spec.rs file
There was a problem hiding this comment.
ok, just making sure that ID works for both if we share that variable for dev and local
There was a problem hiding this comment.
yes it works for 'dev' too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the previous default for
BOOTNODE_ID_LOCALin an .env file prevents generating and finalizing blocks