Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve datetime perf #1202

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

improve datetime perf #1202

wants to merge 6 commits into from

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Sep 11, 2024

benchmark with simple logger.info("hello {}", "b") with os.devnull sink, from 44s to 20s

ref: #1201

@trim21
Copy link
Contributor Author

trim21 commented Sep 11, 2024

looks like we are still running tests on 3.5, so we can't add inline typing or use f-string ...

@trim21
Copy link
Contributor Author

trim21 commented Sep 11, 2024

also, why aware_now use time module instead of using datetime_.now.astimezone and combine it as datetime?

@trim21
Copy link
Contributor Author

trim21 commented Sep 11, 2024

I think we can also include a fast path for default datetime format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant