-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 32 bit support #229
Add 32 bit support #229
Conversation
The latest ubuntu I can find to test this on is https://mirror.it.ubc.ca/ubuntu-releases/16.04/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall.
@@ -11,6 +11,9 @@ use crate::channel_value::ChannelValue; | |||
/// Default [`nix_package_url`](CommonSettings::nix_package_url) for Linux x86_64 | |||
pub const NIX_X64_64_LINUX_URL: &str = | |||
"https://releases.nixos.org/nix/nix-2.12.0/nix-2.12.0-x86_64-linux.tar.xz"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not in this PR but:
Should we be bumping the Nix version? Latest stable is already 2.13.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya! I was bumping it in #196 but that is delayed so I can do that separately.
Description
Closes #219.
TODO:
Checklist
cargo fmt
nix build
nix flake check
Validating with
install.determinate.systems
If a maintainer has added the
upload to s3
label to this PR, it will become available for installation viainstall.determinate.systems
: