Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 32 bit support #229

Merged
merged 5 commits into from
Feb 6, 2023
Merged

Add 32 bit support #229

merged 5 commits into from
Feb 6, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

Closes #219.

TODO:

  • Add buildkite job
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this Feb 1, 2023
@Hoverbear Hoverbear added this to the v0.2.1 milestone Feb 1, 2023
@Hoverbear Hoverbear added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Feb 1, 2023
@Hoverbear
Copy link
Contributor Author

The latest ubuntu I can find to test this on is https://mirror.it.ubc.ca/ubuntu-releases/16.04/

@Hoverbear Hoverbear added the Linux label Feb 1, 2023
@Hoverbear
Copy link
Contributor Author

image
It works!

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@@ -11,6 +11,9 @@ use crate::channel_value::ChannelValue;
/// Default [`nix_package_url`](CommonSettings::nix_package_url) for Linux x86_64
pub const NIX_X64_64_LINUX_URL: &str =
"https://releases.nixos.org/nix/nix-2.12.0/nix-2.12.0-x86_64-linux.tar.xz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not in this PR but:

Should we be bumping the Nix version? Latest stable is already 2.13.2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya! I was bumping it in #196 but that is delayed so I can do that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linux upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

32 bit x86 support?
2 participants