Attempt to minimize steam deck display manager restart risk #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoverbear
added
bug
|
Interesting, I experienced the bug this time when I was testing my install on the deck. |
|
I seem to be no longer able to reproduce it. |
Hoverbear
commented
Feb 6, 2023
src/planner/linux/steam_deck.rs
Outdated
| @@ -188,7 +189,7 @@ impl Planner for SteamDeck { | |||
| Type=oneshot\n\ | |||
| RemainAfterExit=yes\n\ | |||
| ExecStart=/usr/bin/systemctl daemon-reload\n\ | |||
| ExecStart=/usr/bin/systemctl restart --no-block sockets.target timers.target multi-user.target\n\ | |||
| ExecStart=/usr/bin/systemctl start --no-block sockets.target timers.target multi-user.target\n\ | |||
There was a problem hiding this comment.
This is the load bearing line of the fix, the above line is is more assurance than a fix.
|
So, changing from |
cole-h
approved these changes
Feb 8, 2023
Hoverbear
deleted the
attempt-to-minimize-chance-of-display-manager-restarts
branch
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This attempts to address #235 with the information at hand. My best suspicion is that this is the display manager restarting.
Checklist
cargo fmtnix buildnix flake checkValidating with
install.determinate.systemsIf a maintainer has added the
upload to s3label to this PR, it will become available for installation viainstall.determinate.systems: