-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the correct permissions on the zshenv #257
Merged
Hoverbear
merged 6 commits into
main
from
hoverbear/ds-681-macos-newly-created-zshenv-doesnt-have
Feb 21, 2023
Merged
Set the correct permissions on the zshenv #257
Hoverbear
merged 6 commits into
main
from
hoverbear/ds-681-macos-newly-created-zshenv-doesnt-have
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI, why
cole-h
reviewed
Feb 17, 2023
Also updated the error message a user might get. |
6 tasks
Hoverbear
deleted the
hoverbear/ds-681-macos-newly-created-zshenv-doesnt-have
branch
February 21, 2023 15:28
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm a bit curious how we didn't catch #254 in testing, since we do that
nix
is on path:nix-installer/.github/workflows/ci.yml
Lines 123 to 126 in c150d60
And that should have failed....
Checklist
cargo fmt
nix build
nix flake check
Validating with
install.determinate.systems
If a maintainer has added the
upload to s3
label to this PR, it will become available for installation viainstall.determinate.systems
: