Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup a couple differences with the official installer scripts #311

Merged

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Mar 7, 2023

Description

Found while working on #126 when testing against the official installer:

Screenshot from 2023-03-07 09-55-22
Screenshot from 2023-03-07 09-56-36

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this Mar 7, 2023
@cole-h
Copy link
Member

cole-h commented Mar 7, 2023

Ah, this is probably the true fix, rather than #278. I didn't realize upstream used 664 for some of these files...

We should probably audit the other file modes and make sure they match upstream, as well as leave a comment at each of those sites so that I don't make the same mistake 😅

@Hoverbear
Copy link
Contributor Author

I'll be adding tests with curing that ensure we can install over the old scripts, which necessarily means the modes must be the same!

@Hoverbear Hoverbear force-pushed the fixup-differences-in-permissions-with-official-installer branch from 152dd44 to 09e2947 Compare March 7, 2023 21:12
@Hoverbear Hoverbear added this to the v0.6.0 milestone Mar 8, 2023
@Hoverbear Hoverbear marked this pull request as ready for review March 8, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants