Default to systemd, refer to documentation if systemd is not available #336
Conversation
| @@ -147,6 +147,21 @@ jobs: | |||
| run: nix build . | |||
| ``` | |||
|
|
|||
| ## Without systemd (Linux only) | |||
There was a problem hiding this comment.
Maybe this shouldn't be the second "use case", but somewhat lower?
But also I want this to be visible before the other below use cases that specify --init none... Could just add a link back in place of their "> When --init none is..." notices.
There was a problem hiding this comment.
Your preference here. I think this is a fine location but am not picky!
There was a problem hiding this comment.
Myeah, I think this is fine for now. We can always add more docs / more backlinking!
cole-h
changed the title
| @@ -75,6 +75,13 @@ impl ConfigureInitService { | |||
| }, | |||
| #[cfg(target_os = "linux")] | |||
| InitSystem::Systemd => { | |||
| // If /run/systemd/system exists, we can be reasonably sure the machine is booted | |||
| // with systemd: https://www.freedesktop.org/software/systemd/man/sd_booted.html | |||
| if !(Path::new("/run/systemd/system").exists() || which::which("systemctl").is_ok()) | |||
There was a problem hiding this comment.
Related to #392. On WSL without systemd running, the systemctl command does exist (Ubuntu 22.04.1 from the windows store). So this check would not error, even though systemd needs to be configured in /etc/wsl.conf. It would also be good to point users to the microsoft docs where they document on how to configure this, or maybe even configure the file for people so they only have to reboot.
Note that /run/systemd/system does not exist, so if the check only looked for that it would error succesfully
There was a problem hiding this comment.
Thanks for tracking this down!
| @@ -75,6 +75,13 @@ impl ConfigureInitService { | |||
| }, | |||
| #[cfg(target_os = "linux")] | |||
| InitSystem::Systemd => { | |||
| // If /run/systemd/system exists, we can be reasonably sure the machine is booted | |||
| // with systemd: https://www.freedesktop.org/software/systemd/man/sd_booted.html | |||
| if !(Path::new("/run/systemd/system").exists() || which::which("systemctl").is_ok()) | |||
There was a problem hiding this comment.
This could be a case of a simple logic error, as in, the following would work:
-if !(Path::new("/run/systemd/system").exists() || which::which("systemctl").is_ok())
---
+if (!Path::new("/run/systemd/system").exists() || !which::which("systemctl").is_ok())Although I'm not sure what the original intention was
…able
Description
Closes #308.
Checklist
cargo fmtnix buildnix flake checkValidating with
install.determinate.systemsIf a maintainer has added the
upload to s3label to this PR, it will become available for installation viainstall.determinate.systems:We used to default to
InitSystem::Noneif we couldn't detectsystemd, but that form of running has some drawbacks (well, one drawback: only root and root-privileged users can use Nix), but that would lead to not obviously-broken installations for users who expected it to work without root.We now make
InitSystem::Systemdthe default and error if/run/systemd/systemdoesn't exist andsystemctldoes not exist in the PATH (apparently the second may succeed on podman...? cc @Hoverbear you suggestedsystemd-daemon, but that doesn't exist for me, so I went with the other obvious indication ofsystemd).This error suggests
--init none, which we used to fall back to, but also links to some (brief) documentation in our README on the drawbacks of installing withInitSystem::None.