Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default_missing_value to default_value #380

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

We don't need to do this anymore. It was some change I was testing that didn't work, and I forgot to remove it.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

We don't need to do this anymore. It was some change I was testing that
didn't work, and I forgot to remove it.
@Hoverbear Hoverbear added this to the v0.6.1 milestone Mar 28, 2023
@Hoverbear Hoverbear requested a review from cole-h March 28, 2023 16:39
@Hoverbear Hoverbear self-assigned this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants