Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time machine exclusions for Mac #480

Merged
merged 10 commits into from
May 31, 2023
Merged

Add time machine exclusions for Mac #480

merged 10 commits into from
May 31, 2023

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented May 24, 2023 •
edited
Loading

Description

Fixes #479 most likely?

image

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this May 24, 2023
@Hoverbear Hoverbear added this to the 0.9.1 milestone May 26, 2023
@Hoverbear Hoverbear modified the milestones: 0.9.1, 0.9.2 May 26, 2023
@Hoverbear Hoverbear added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label May 26, 2023
@Hoverbear Hoverbear marked this pull request as ready for review May 26, 2023 20:51
@Hoverbear Hoverbear added the MacOS Darwin/MacOS label May 26, 2023
cole-h
cole-h previously approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit unfortunate that this is necessary, but it will hopefully improve the UX when e.g. uninstalling.

@Hoverbear
Copy link
Contributor Author

(Holding merge until after #484 since this breaks plan.jsons)

@cole-h cole-h dismissed their stale review May 26, 2023 21:11

prevent merging before we're ready

@Hoverbear Hoverbear merged commit 7ec5148 into main May 31, 2023
@Hoverbear Hoverbear deleted the hoverbear/ds-901-macos-uninstall-backupd-hampers-uninstall branch May 31, 2023 20:36
@lucperkins lucperkins mentioned this pull request Jun 16, 2023
Merged
@abathur abathur mentioned this pull request Jul 13, 2023
Open
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
MacOS Darwin/MacOS upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

MacOS uninstall - Backupd hampers uninstall
2 participants
@Hoverbear @cole-h