Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use os-release to determine appropriate planner #501

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Use os-release to determine appropriate planner #501

merged 3 commits into from
Jun 1, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

Notably, auto detect steam decks. This also will interact with #389 in the future.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear added the Linux label Jun 1, 2023
@Hoverbear Hoverbear added this to the 0.9.2 milestone Jun 1, 2023
@Hoverbear Hoverbear self-assigned this Jun 1, 2023
@Hoverbear Hoverbear requested a review from cole-h June 1, 2023 17:45
cole-h
cole-h reviewed Jun 1, 2023
View reviewed changes
src/planner/mod.rs Outdated Show resolved Hide resolved
src/planner/mod.rs Outdated Show resolved Hide resolved
cole-h
cole-h reviewed Jun 1, 2023
View reviewed changes
src/planner/mod.rs Outdated Show resolved Hide resolved
cole-h
cole-h approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cole-h cole-h merged commit 1d51b25 into main Jun 1, 2023
@cole-h cole-h deleted the hoverbear/ds-915-explore-heuristically-defaulting-to-steam-deck-planner-where branch June 1, 2023 20:00
@lucperkins lucperkins mentioned this pull request Jun 16, 2023
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
Linux
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoverbear @cole-h