Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix darwin devShell #514

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Fix darwin devShell #514

merged 2 commits into from
Jun 14, 2023

Conversation

mkenigs
Copy link
Contributor

@mkenigs mkenigs commented Jun 14, 2023 •
edited
Loading

  • SELinux tools are Linux specific
  • The Security framework is needed by cargo build

@mkenigs
Move Linux only dependencies to isLinux block
ecf6138 
SELinux tools are Linux specific
@mkenigs
Add apple_sdk Security framework to devShell
741b28d 
Otherwise cargo build fails with:
ld: framework not found Security
@mkenigs mkenigs changed the title Move Linux only dependencies to isLinux block Fix darwin devShell Jun 14, 2023
cole-h
cole-h approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@Hoverbear Hoverbear added this to the 0.9.2 milestone Jun 14, 2023
@Hoverbear Hoverbear merged commit 47f2630 into DeterminateSystems:main Jun 14, 2023
@Hoverbear
Copy link
Contributor

Thanks @mkenigs :)

@mkenigs mkenigs deleted the linux-specific branch June 15, 2023 15:39
@lucperkins lucperkins mentioned this pull request Jun 16, 2023
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoverbear Hoverbear Hoverbear approved these changes

@cole-h cole-h cole-h approved these changes

Assignees

@mkenigs mkenigs

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mkenigs @Hoverbear @cole-h