-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ostree-based Linux distributions #586
Conversation
Fixes DeterminateSystems#389 I've tested this planner on Fedora Silverblue and Endless OS
Thanks for this! I'll need to do some testing. :) (Don't worry about the CI failures here -- We need to rework our CI to better handle contributor PRs apparently...) |
It's a real bummer I can't seem to find any official silverblue vagrant boxes to use in the VM tests. |
plan.push(ensure_symlinked_units_resolve_unit.boxed()); | ||
|
||
// We need to remove this path since it's part of the read-only install. | ||
let mut shell_profile_locations = ShellProfileLocations::default(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should make ShellProfileLocations::default()
check if the items if candidate paths are read-only and exclude them...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played a bit with this, but couldn't find a good way to do this.
One alternative would be to stop erroring when this files cannot be created and logging warnings instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's punt it for now. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what that means 😅
I found a few very minor tidy-ups and nits to address, otherwise this seems to work really well! Thanks so much!
|
Thanks for this! |
Fixes #389
I've tested this planner on Fedora Silverblue and Endless OS.
The content is inspired by the linux planner, the steamos planner and https://github.com/dnkmmr69420/nix-installer-scripts/blob/main/installer-scripts/silverblue-nix-installer.sh
Description
Checklist
cargo fmt
nix build
nix flake check
Validating with
install.determinate.systems
If a maintainer has added the
upload to s3
label to this PR, it will become available for installation viainstall.determinate.systems
: