Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for file existence before attempting to open it #626

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

Fixes #625

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Sep 8, 2023
@Hoverbear Hoverbear added this to the 0.11.1 milestone Sep 8, 2023
@Hoverbear Hoverbear self-assigned this Sep 8, 2023
@Hoverbear Hoverbear marked this pull request as ready for review September 12, 2023 16:21
@Hoverbear Hoverbear merged commit b3dcf07 into main Sep 13, 2023
13 checks passed
@Hoverbear Hoverbear deleted the check-existence-in-create-file branch September 13, 2023 16:55
@Hoverbear Hoverbear mentioned this pull request Sep 22, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Uninstalling following Failed GitHub Action
2 participants