Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for URLs or paths in --nix-package-url and --extra-conf #634

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

During testing I quite often want to pass file paths to --nix-package-url, the file:/// URL bits always trip me up and require me to think about my cwd etc. This PR tidies up some related code and adds a similar functionality to the --extra-conf such that I can pass something that looks like a URL or file path and have it just work.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear added this to the 0.11.1 milestone Sep 18, 2023
@Hoverbear Hoverbear self-assigned this Sep 18, 2023
src/settings.rs Outdated Show resolved Hide resolved
src/settings.rs Outdated Show resolved Hide resolved
@Hoverbear Hoverbear enabled auto-merge (squash) September 20, 2023 18:36
@Hoverbear Hoverbear merged commit abfde74 into main Sep 20, 2023
13 checks passed
@Hoverbear Hoverbear deleted the handle-paths-in-nix-package-url branch September 20, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants