[HOTFIX] API Credential failed 문제로 다른 API로 변경 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoonyoungL
requested review from
DoAY9,
Genesis2010,
glitterer,
SohyeonKim-dev,
HeejiSohn and
lenamin
lenamin
approved these changes
Jan 30, 2024
| @@ -80,6 +77,7 @@ extension HorizonsAPIManager { | |||
| // Get time now and 1 minute later | |||
|
|
|||
| let formatter = DateFormatter() | |||
| formatter.timeZone = TimeZone(identifier: "Europe/London") | |||
There was a problem hiding this comment.
타임존때문에 값이 낮인 것처럼 나왔던거군요!
받아오는 값이 정확히 일치합니다. 정말 고생하셨어요 제리!!!
|
확인 마쳤습니다! 현재 미국 Providence, Rhode Island에서도 작동 잘하고 있습니다. |
glitterer
approved these changes
Jan 30, 2024
| @@ -41,3 +42,64 @@ extension AstronomyAPIManager { | |||
| return parameters | |||
| } | |||
| } | |||
|
|
|||
| // MARK: - Horizons API | |||
| class HorizonsAPIManager: NetworkService { | |||
There was a problem hiding this comment.
궁금해서 그런건데, 현재 이 horizons API에 대한 코드는 그럼 아예 새로 이 API에 대해서 작성을 새로 하신건가요..?!
There was a problem hiding this comment.
기존에 있던 걸 참고해서 따로 만들었습니다!
Comment on lines
+86
to
+105
| var command: String { | ||
| switch self { | ||
| case .sun: | ||
| return "10" | ||
| case .moon: | ||
| return "301" | ||
| case .mercury: | ||
| return "199" | ||
| case .venus: | ||
| return "299" | ||
| case .mars: | ||
| return "499" | ||
| case .jupiter: | ||
| return "599" | ||
| case .saturn: | ||
| return "699" | ||
| case .uranus: | ||
| return "799" | ||
| case .neptune: | ||
| return "899" |
There was a problem hiding this comment.
바쁘실텐데 죄송합니다. 궁금해서 그런건데, 혹시 이 숫자들의 의미는 어디에서 오는건가요..? API에서 각 행성들에 대한 숫자인건가요? ㅎㅎ,,,
There was a problem hiding this comment.
아 이건 설명을 못 썼네요.. 임시로 바꾼 API에서는 원하는 천체를 파라미터로 보내서 값을 요청하는데 그때 쓰는 숫자들입니다 API에서 각 행성들에 대한 숫자가 맞아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
🔒 Closes
#103
작업내용
추후 진행할 사항
리뷰포인트
Reference
NASA Open APIs
Horizons API
Horizons System Manual
Checklist