Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where content of floating window is set to inactive #466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpondo
Copy link
Contributor

@mpondo mpondo commented Dec 11, 2023

We'd like to remove code that is setting the content of the floating window to inactive when the window becomes inactive.

This code was introduced in #410. The commit fixes an issue with activating the content, but it assumes that it should also deactivate the content. However, deactivating the content introduces new behavior. In our usage, this resulted in multiple issues, because we have child windows that popup and are no longer activating correctly because the parent floating window is no longer active.

To demonstrate the issue, I added a document with a button to open a simple message box to the TestApp. If you open the message box from a document docked in the main window, the document remains active (as shown by the blue tab and bar). However, when the document is in a floating window, opening the message box causes the document to become inactive. I would have expected the behavior to be th same in both cases.

Video of bug:
AvalonDock-DeactivateWindow-Bug

Here is a video of the fix. It also validates that the new code maintains the behavior of the original fix from #410.
AvalonDock-DeactivateWindow-Fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant