This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
add support for preactivate_feature, is_feature_activated, and get_sender intrinsics; move definition of new set_proposed_producers function #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implementation of the set_proposed_producers overload using the set_proposed_producers_ex intrinsic into an inline function defined in the header to prevent pulling in WASM imports that make the contract invalid on a pre-2.0 EOSIO chain.
arhag
changed the title
larryk85
approved these changes
Sep 18, 2019
rise-worlds
pushed a commit
to potato-coin/eosio.cdt
that referenced
this pull request
Jul 14, 2020
add support for preactivate_feature, is_feature_activated, and get_sender intrinsics; move definition of new set_proposed_producers function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added support for the
preactivate_feature,is_feature_activated, andget_senderintrinsics.Temporarily moved the implementation of the new
set_proposed_producersoverload introduced in PR #570 from theeosiolib.cppfile to an inline function defined in theprivileged.hppheader file. This is to workaround a issue in CDT which brings in all imported intrinsics used within an object file (e.g.eosiolib.cpp.obj) that is linked into the compiled WebAssembly file, even if those intrinsics aren't actually used in any of the contract code. This means that prior to this change, a contract designed to work with EOSIO v1.8.x only would likely inadvertently bring in a dependency to theset_proposed_producers_exintrinsic (a v2.0.x and above feature) within the compiled WASM and thus make it impossible to deploy on a v1.8.x blockchain. If CDT fixes this issue in the future, the implementation ofset_proposed_producerscan be moved back into the .cpp file (along with a lot of other functions that are currently defined in header files).API Changes
Documentation Additions